Repository navigation
Fix Anima text encoder exports and standalone core denoising - #14943
Open
lucasruan1618 wants to merge 1 commit into
Open
lucasruan1618 wants to merge 1 commit into
lucasruan1618 wants to merge 1 commit into
Conversation
Contributor
|
Hi @lucasruan1618, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. Please note that PRs without a linked issue are likely to be automatically closed 10 days after this notice. Once the PR links an issue (or gets the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Anima text encoder exports and standalone core denoising
What does this PR do?
Fixes two issues when running Anima's modular stages as separate pipelines.
AnimaTextEncoderStepproduces eight Qwen/T5 conditioning tensors, but none is tagged withkwargs_type="denoiser_input_fields". Consequently, the documented split-pipeline workflow:exports an empty dictionary and fails with
Required input 'qwen_prompt_embeds' is missing. This PR adds the tag to all eight outputs, applying the same fix pattern as #14925.Separately,
AnimaCoreDenoiseStepdoes not require a VAE, but latent preparation readsvae_scale_factor, whose property accessesself.vaedirectly. Running that block standalone therefore raisesAttributeError: 'AnimaModularPipeline' object has no attribute 'vae_scale_factor'. This PR allows the property to return its existing default of 8 when the VAE component is absent. Pipelines with a VAE continue to use its configured scale factor.The source changes are eight output tags and one component lookup. Regression tests cover split execution with omitted, empty, and non-empty negative prompts, comparing generated images against the complete pipeline. A separate test passes encoded tensors by name to the standalone core denoiser and checks the resulting latent shape and finite values.
Validation
TestBlockKwargsTypeInputstests: 4 passed.make style,make fix-copies,make quality, andgit diff --check: passed.Tests use real components from
hf-internal-testing/tiny-anima-modular-pipe. Production-size checkpoints were not tested.Self-review notes
Reviewed against
.ai/references/review-rules.md,code_style.md,modular.md, andtesting.md, following.ai/skills/self-review.Before submitting
Who can review?
@yiyixuxu