[Cosmos3] Fix Transfer SeaCache artifacts with control CFG - #14897
Open
yzhautouskay wants to merge 2 commits into
Open
yzhautouskay wants to merge 2 commits into
yzhautouskay wants to merge 2 commits into
Conversation
10 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow-up to #14663
Fixes Cosmos3 Transfer quality artifacts when SeaCache is combined with control CFG. The cache indicator now uses only noisy target latents, excluding separate clean control-hint latents. Control hints still condition the transformer, and each CFG branch retains its own residual history.
Validation:
make styleandmake fix-copiespassedSelf-review: READY. No blocking, non-blocking, or dead-code findings.
Test results
The current cache quality issue is input-dependent because control-CFG branch schedules can diverge very differently across examples, independent of the control type alone. Some show little degradation, while others develop severe temporal/block artifacts. The effect is amplified with FP8-quantized checkpoints.
This PR addresses the observed flickering and severe degradation in both BF16 and FP8 runs. All six example/precision comparisons improve LPIPS, PSNR, and SSIM against their matching uncached baseline.
Rows: BF16 (top), FP8 (bottom).
Columns, left to right: uncached / current cache / this PR fix.
Videos include latency, speedup, LPIPS, PSNR, and SSIM.
diffusers_0200_edge_six_arm.mp4
diffusers_0539_seg_six_arm.mp4
Before submitting
self-reviewskill on the diff?documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.