Skip to content

FlaxStableDiffusionImg2ImgPipeline should delete prepare_inputs and provide prepare_text_inputs and prepare_image_inputs #9371

Open

Description

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...].
in https://github.com/huggingface/diffusers/blob/main/src/diffusers/pipelines/stable_diffusion/pipeline_flax_stable_diffusion_img2img.py#L170
prepare_inputs(self, prompt: Union[str, List[str]], image: Union[Image.Image, List[Image.Image]]) accept both prompt and image
But there are prompt_ids and neg_prompt_ids in https://github.com/huggingface/diffusers/blob/main/src/diffusers/pipelines/stable_diffusion/pipeline_flax_stable_diffusion_img2img.py#L338 which prompt (positive or negative) I should put to prepare_inputs?

Describe the solution you'd like.
A clear and concise description of what you want to happen.
like https://github.com/huggingface/diffusers/blob/main/src/diffusers/pipelines/controlnet/pipeline_flax_controlnet.py#L180 and https://github.com/huggingface/diffusers/blob/main/src/diffusers/pipelines/controlnet/pipeline_flax_controlnet.py#L194
delete prepare_inputs and provide prepare_text_inputs and prepare_image_inputs

Describe alternatives you've considered.
A clear and concise description of any alternative solutions or features you've considered.

Additional context.
Add any other context or screenshots about the feature request here.

Activity

  1. github-actions commented on Oct 5, 2024

    @github-actions
    Contributor

    This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

    Please note that issues that do not follow the contributing guidelines are likely to be ignored.

  2. sayakpaul commented on Nov 1, 2024

    @sayakpaul
    Member
  3. github-actions commented on Nov 25, 2024

    @github-actions
    Contributor

    This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

    Please note that issues that do not follow the contributing guidelines are likely to be ignored.

  4. removed
    staleIssues that haven't received updates
    on Nov 25, 2024
  5. github-actions commented on Dec 20, 2024

    @github-actions
    Contributor

    This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

    Please note that issues that do not follow the contributing guidelines are likely to be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    staleIssues that haven't received updates

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions