You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Handle kwargs and not serializable values as configuration attributes #657
A kwargs argument was added to schedulers in d7dcba4 just to display a deprecation warning. kwargs was interpreted as a configurable attribute, but it could not be serialized. This broke:
Pipeline loading, via __repr__ in the warning message.
Pipeline saving.
We just added a quick fix, but there were other ideas to address it. @anton-l proposed the following in
Perhaps we should do this in a more general way and prevent accepting attributes that cannot be serialized, informing the user about the problem. A similar thing happened for dtype and is bound to happen again.
My first approach would be to attempt a JSON serialization in register_to_config and go from there, but I'm not fully familiar with the details of the code. Any thoughts?
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.
Please note that issues that do not follow the contributing guidelines are likely to be ignored.
Activity
patrickvonplaten commentedon Oct 5, 2022
I think the solution we have for now is good enough actually - what do you think @pcuenca ?
github-actions commentedon Oct 29, 2022
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.
Please note that issues that do not follow the contributing guidelines are likely to be ignored.
pcuenca commentedon Oct 30, 2022
Sounds good.
[SD] Add support for a compiled version of the discrete Euler schedul…