Skip to content

callback_steps is typed as Optional[int] but has a default value #2343

Description

@williamberman

In pipelines, we pass both a callback and a callback_steps. callback_steps is always set and has a default value of 1. callback is optional. We always type callback_steps incorrectly as Optional[int] instead of just int. We should update the type signatures of callback_steps.

#2297 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions