Skip to content

Better image interpolation in training scripts follow up #11390

Description

@asomoza

With #11206 we did a small quality improvement for the SDXL Dreambooth LoRA script by making LANCZOS the default interpolation mode for the image resizing.

This issue is to ask for help from the community to bring this change to the other training scripts, specially for the popular ones.

Since this is a really easy to make contribution I'll ask that we leave this issue for beginners and people that want to start learning how to contribute to open source projects.

What I think are the most important ones:

If you have other preference, please feel free to ask me to add it.

If you want to contribute just answer to this issue with the one you want to do and tag me in the PR. Please only take one since I want to use this issue to get people to learn the ropes on how to contribute and get started with open source.

Activity

  1. self-assigned this
    on Apr 23, 2025
  2. ishandutta0098 commented on Apr 23, 2025

    @ishandutta0098
    Contributor

    Hi @asomoza I would like to contribute to train_dreambooth_flux

  3. merterbak commented on Apr 25, 2025

    @merterbak
    Contributor

    Hi, I want to contribute to train_dreambooth_lora

  4. tongyu0924 commented on Apr 27, 2025

    @tongyu0924
    Contributor

    Hi, I want to contribute to train_text_to_image

  5. YoulunPeng commented on Apr 29, 2025

    @YoulunPeng
    Contributor

    Hi, all! I will help with this one train_controlnet_flux

    Here is the PR #11449

  6. 11 remaining items

  7. RogerSinghChugh commented on May 5, 2025

    @RogerSinghChugh
    Contributor

    Hi @asomoza I would like to contribute to train_text_to_image_sdxl.

    Will try to create a PR as soon as possible.

  8. asomoza commented on May 5, 2025

    @asomoza
    MemberAuthor

    sorry @RogerSinghChugh there was a PR for train_text_to_image_sdxl last week and I did a review of it, only was pending the merge, so even if it wasn't announced here, it was almost finished. Can you please choose another one? maybe train_text_to_image_lora_sdxl?

  9. RogerSinghChugh commented on May 5, 2025

    @RogerSinghChugh
    Contributor

    sorry @RogerSinghChugh there was a PR for train_text_to_image_sdxl last week and I did a review of it, only was pending the merge, so even if it wasn't announced here, it was almost finished. Can you please choose another one? maybe train_text_to_image_lora_sdxl?

    Sure no worries, will try to do that instead

  10. ParagEkbote commented on May 5, 2025

    @ParagEkbote
    Contributor

    I've also opened a PR for train_text_to_image_lora_sdxl. I forgot to post it on this thread. Could you please review it?

    cc: @asomoza

  11. RogerSinghChugh commented on May 5, 2025

    @RogerSinghChugh
    Contributor
  12. asomoza commented on May 5, 2025

    @asomoza
    MemberAuthor

    I've also opened a PR for train_text_to_image_lora_sdxl. I forgot to post it on this thread. Could you please review it?

    @ParagEkbote since this issue became busy, let's just do one for each person so we can let the others also contribute and learn please

  13. ParagEkbote commented on May 5, 2025

    @ParagEkbote
    Contributor

    Are there any other backlog/longstanding issues that you would like me to contribute towards?

    cc: @asomoza

  14. reopened this on May 5, 2025
  15. asomoza commented on May 5, 2025

    @asomoza
    MemberAuthor

    Are there any other backlog/longstanding issues that you would like me to contribute towards?

    @ParagEkbote depends on your level of knowledge of diffusers, python and pytorch. We have several open issues for the community to contribute.

    You can read them here but this one is the easiest one for first time contributors, the others require more work to get them done.

    Nevertheless, I'm always looking and posting some easy to do issues for people to learn the ropes, hopefully I will have some more soon.

  16. reopened this on May 5, 2025
  17. asomoza commented on May 5, 2025

    @asomoza
    MemberAuthor

    thanks everyone! We're done with the ones I posted, if anyone finds and wants to do some other training script that I missed, please don't hesitate to post it here and I'll reopen the issue and add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions