Repository navigation
Forward all generation options to FoundationModels - #230
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified, and the changes include conversion tests.
Pull request overview
Updates SystemLanguageModel to forward all generation options to FoundationModels.
Changes:
- Maps greedy, top-k, and nucleus sampling, including seeds.
- Forwards temperature and maximum response tokens.
- Adds tests for option conversion and nil defaults.
File summaries
| File | Description |
|---|---|
Tests/AnyLanguageModelTests/SystemLanguageModelTests.swift |
Verifies option conversion behavior. |
Sources/AnyLanguageModel/Models/SystemLanguageModel.swift |
Converts supported generation options to FoundationModels. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GenerationOptions.toFoundationModels()only forwarded temperature, causingSystemLanguageModelto ignore sampling modes andmaximumResponseTokens. This forwards greedy, top-k, and nucleus sampling (including seeds), forwards the maximum token limit, and preserves nil defaults.