Skip to content

Add support for repository searching by "topic" - #439

Merged
kohsuke merged 1 commit into
hub4j:masterfrom
l3ender:master
Aug 30, 2018
Merged

Add support for repository searching by "topic"#439
kohsuke merged 1 commit into
hub4j:masterfrom
l3ender:master

Conversation

@l3ender

@l3ender l3ender commented Jun 6, 2018

Copy link
Copy Markdown
Contributor

@ToWi87

ToWi87 commented Jun 7, 2018

Copy link
Copy Markdown

👍 for the idea and the code, here the related docs:
https://developer.github.com/v3/search/#search-topics
Question coming up here:
Are there no additions needed regarding the additional header needed as stated in the docs?

@oleg-nenashev oleg-nenashev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@l3ender

l3ender commented Jun 7, 2018

Copy link
Copy Markdown
Contributor Author

@ToWi87 The doc you linked to is for searching/retrieving topics (/search/topics). This PR is for using topics to search/retrieve repositories (/search/repositories).

If/when there is a desire to integrate searching of topics, then there will likely be need to spend effort on the header information that you mentioned.

Thank you.

@ToWi87

ToWi87 commented Jun 8, 2018

Copy link
Copy Markdown

true that, sorry for the confusion.
I'd like to have the search API also work for topics but I'd wait for GitHub to release the feature without the 'beta' header.

@kohsuke
kohsuke merged commit ca55947 into hub4j:master Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants