back to io/wait - #368

Closed

HoneyryderChuck wants to merge 29 commits into

httprb:masterfrom

HoneyryderChuck:issue_357

Commits on Jan 28, 2017

reverting the previous io/wait commits as a first measure, and reproducing the previous errors

Tiago Cardoso
authored and
Tiago Cardoso
committed
2590ac2
added helper methods to the response, which will help inferring the proper content length to read from socket
Tiago Cardoso
committed
5a25cb7
added alternative debugger for ruby > 2.0
Tiago Cardoso
committed
b04a0db
enhanced the master branch #content_length implementation, regarding RFC compliance
Tiago Cardoso
committed
f5b22e5
passing content length to response body; when set, read until length is exhausted
Tiago Cardoso
committed
ca55acf
CI has old version of bundler, and I can't set the newest platforms... shame
Tiago Cardoso
committed
21f9d34
tolerating the first timeout on read/write wait; like in the failing case, the socket is anyway going to be closed by the server, so allow to try a read one more time; if it's eof, all good, otherw…
Tiago Cardoso
committed
4a39a8b
added general header error, left the existing custom one for back-comp
Tiago Cardoso
committed
f79bf10
wrong format for content length doesn't raise error, which doesn't please me, but oh well
Tiago Cardoso
committed
f0f0231
corrected some faults coming from latest rebase
Tiago Cardoso
committed
48c3e85
explicit nil
Tiago Cardoso
committed
93c9ce9
do not needlessly call the method, use the ivar
Tiago Cardoso
committed
73f0816
Headers#get always returns an array, so work only with that; also, use Headers#include? to reduce allocations
Tiago Cardoso
committed
00279ae
use Headers#include? to reduce allocations, add header conditions together
Tiago Cardoso
committed
9a2dea1
according to RFC, response is only chunked only if the transfer encoding ends with chunked
Tiago Cardoso
committed
c36d357
added comment for future refactoring
Tiago Cardoso
committed
83f3b32
removed the extra include? call over there

Tiago Cardoso
authored and
Tiago Cardoso
committed
08ec27d
rubocoping
Tiago Cardoso
committed
9c18fe3

Commits on Jan 30, 2017

rubocop <3 ...
Tiago Cardoso
committed
6a13e2a

Commits on Feb 3, 2017

reintegrated kwargs in the body API, and passing the content length down
Tiago Cardoso
committed
108e127
rubo rubo rubocop
Tiago Cardoso
committed
607e42b
rubocop, make up your mind...
Tiago Cardoso
committed
4a90c6c
removing deprecation
Tiago Cardoso
committed
21c0f60
removed tests with deprecated error..
Tiago Cardoso
committed
7fc577b
rubocop again...
Tiago Cardoso
committed
5b19215
more ruboscosps...
Tiago Cardoso
committed
8d84978
Merge branch 'master' into issue_357
HoneyryderChuck
authored
0346723

Commits on Feb 6, 2017

Merge branch 'master' into issue_357
HoneyryderChuck
authored
a77e80e
rbc
Tiago Cardoso
committed
a6afeeb

Navigation Menu

Uh oh!

back to io/wait - #368

back to io/wait#368
HoneyryderChuck wants to merge 29 commits into
httprb:masterfrom
HoneyryderChuck:issue_357

Commits on Jan 28, 2017

reverting the previous io/wait commits as a first measure, and reproducing the previous errors

added helper methods to the response, which will help inferring the proper content length to read from socket

added alternative debugger for ruby > 2.0

enhanced the master branch #content_length implementation, regarding RFC compliance

passing content length to response body; when set, read until length is exhausted

CI has old version of bundler, and I can't set the newest platforms... shame

tolerating the first timeout on read/write wait; like in the failing case, the socket is anyway going to be closed by the server, so allow to try a read one more time; if it's eof, all good, otherw…

added general header error, left the existing custom one for back-comp

wrong format for content length doesn't raise error, which doesn't please me, but oh well

corrected some faults coming from latest rebase

explicit nil

do not needlessly call the method, use the ivar

Headers#get always returns an array, so work only with that; also, use Headers#include? to reduce allocations

use Headers#include? to reduce allocations, add header conditions together

according to RFC, response is only chunked only if the transfer encoding ends with chunked

added comment for future refactoring

removed the extra include? call over there

rubocoping

Commits on Jan 30, 2017

rubocop <3 ...

Commits on Feb 3, 2017

reintegrated kwargs in the body API, and passing the content length down

rubo rubo rubocop

rubocop, make up your mind...

removing deprecation

removed tests with deprecated error..

rubocop again...

more ruboscosps...

Merge branch 'master' into issue_357

Commits on Feb 6, 2017

Merge branch 'master' into issue_357

rbc