Repository navigation
Conversation
Signed-off-by: edbfi <326875205+edbfi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
on_retry_commandof Create Manifests always fails.nick-fields/retryexecutes it with/bin/sh(it usesexecSyncwithout a shell; theshellinput only applies tocommand), and the value has no|, so YAML folds the loop onto one line:dash rejects both the here-string and the missing
;beforedone:The manifest lists created before the failure stay in place, so the retries hit
refusing to amend an existing manifest list with no --amend flagand a transient registry error can fail the job.Seen in my
edbfi/sabnzbdrun 37594116659, attempt 1, jobpublish (ghcr.io).First try: five lists were created, then two
docker manifest createcalls hit ghcr.io client timeouts and the cleanup failed with the error above.Second try:
refusing to amendfor those five, plus two more timeouts.Third try: ghcr.io responded again, but six of the seven lists were refused, so the job failed.
Fix
${manifest%% *}is the first field of eachmanifest.listline, which is what theawkcall extracted. The fixed block passesdash -n.