Skip to content

It seems the "method too long" restriction isn't counting the statements correctly #30

Open

Description

@SuperJMN

The advice is triggered in some methods that are smaller than specified number of lines.

Activity

  1. nhamlin-mw commented on Jun 5, 2018

    @nhamlin-mw

    I noticed that a single-line if statement counts as 2, but if I put that inside braces, the same statement counts as 3. It's bad practice to use single-line if statements, so should the braces be counted as a statement?

    Also, the following code evaluates to 5 statements. Is it the declaration, the if, the comparison, and the two return statements?

    int i = 1;
    if (i == 1) return "hey";
    return "uhoh";
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions