Repository navigation
Conversation
- 闈為噾铻嶆潵婧愶紙鏂伴椈/鏂囨。/宸ュ叿锛夊睍绀烘爣棰樸€佺被鍨嬨€佹彁渚涙柟銆佸伐鍏峰弬鏁颁笌鎶撳彇鏃堕棿 - 宸ュ叿缁撴灉涓殑 url 娓叉煋涓哄彲鐐瑰嚮鐨勫閮ㄩ摼鎺ワ紝琛ラ綈鏃㈡湁濂戠害閲屾湭琚睍绀虹殑瀛楁 - 鐘舵€佸尯鏂板寤舵椂鏁版嵁涓庡鎻愪緵鏂瑰璐︽爣璁帮紝鏉ユ簮鍒楄〃鍚屾灞曠ず - 鏉ユ簮鍒楄〃鏀逛负 listbox/option 璇箟骞舵敮鎸佹柟鍚戦敭銆丠ome/End 绉诲姩鐒︾偣 - 琛ュ厖涓嫳鏂囨枃妗堜笌 SourceInspector/citations 鍗曟祴
8 tasks
helsome
requested changes
Oct 18, 2026
helsome
left a comment
Owner
There was a problem hiding this comment.
暂不合入,发现以下新增问题:
- packages/ui/src/components/agent/SourceInspector.tsx:193–204 将工具结果 source.url 直接作为可点击 href;collectCitationSources 仅检查 string,没有协议约束。请限制为 http/https,并使用仓库受控 external-open 路径,补充 file:/data:/自定义协议不会打开及正常 https 可打开的回归。本结论来自源码审查,不声称已执行协议攻击。
- 同文件新增三处 toLocaleString() 会跟随系统语言,而非应用语言。请复用统一日期格式化接口,并覆盖系统与应用语言不同的情况。
另 #30 的完整真实 Copilot 混合数据源/citation 打开录屏验收仍需补齐,不能凭此次部分实现关闭父 Issue。
Owner
|
同步最新 main:#353 已合入(038f20cf2d87e3575ffbe5469967bdf6ef960dc8),现在已有免 API key 的 Yahoo Finance 备用数据源。请同步 main 后复用现有 provider router / market-data 接口,不再把支持范围内的行情验收统一卡在 Longbridge/Massive 凭证上。 支持范围是美股延迟报价、日/周 K 线和简要公司资料;不支持券商账户/持仓、财报、新闻、期权及分钟行情。保留实际 provider、时间与 delayed 标记,不能用缺失数据冒充 0 或“没有事件”。文档明确它是非官方、个人使用范围的接口,可能限流。 针对本 PR:请用 Yahoo 金融来源核对 Inspector 的实际来源与 delayed/fallback 标记。混合来源录屏仍需满足原有模型及网页/文档条件,原链接安全审查要求保持。 参考:接入说明 · 适配器。请区分 fixture 与真实联网结果;连接卡显示 connected 本身不证明实际取数成功。此评论同步新基线,不替代原有 review 或验收结论。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改了什么
SourceInspector之前只对金融证据信封渲染来源详情,新闻/文档/工具来源只显示一句 "no structured envelope"。现在会展示标题、类型、工具名、工具参数、抓取时间,以及可点击的外部链接(target="_blank" rel="noreferrer")。CitationSource.url之前被extractUrl采集但从未渲染;现在工具结果里的url/title会一并提取并展示。delayed(延时数据)与reconciliation(多提供方对账,含 providers + method)标记,与既有的stale/fallback并列。listbox/option语义 + rovingtabIndex,支持ArrowUp/ArrowDown/Home/End移动选中项并把焦点带到新的行。en-US与zh-CN,i18n:check通过。为什么
#30 的验收标准要求"从行内引用到证据的完整路径"。Part 1 已合入标注契约与来源检查器骨架,但非金融来源与状态标记仍然缺失,来源检查器实际只能证明金融信封这一条路径。本 PR 补上剩余部分。
Issue
Refs #30(Part 2)。验收标准里的"真实混合来源 Copilot 回答录制"仍未完成,见下方未完成项。
验证
环境:Windows(Asia/Shanghai),Bun 1.4.2。
新增用例覆盖:非金融来源标题/链接/工具参数渲染、
delayed+reconciliation展示、方向键与 Home/End roving focus、collectCitationSources对新增字段的透传。全量
bun test --isolate:1779 pass / 8 skip / 1 fail。唯一失败是ExperimentService.runExperiment > creates + updates the experiment and persists runs and results,断言experiment.metadata.gitSha为 string。该用例需要.git目录读取 git SHA,而本次验证用的是一份 GitHub tarball 解压树,没有.git,因此与本次改动无关,@finagent/shared也未被本 PR 触碰。未完成项
ANTHROPIC_API_KEY),当前环境只有非 Anthropic 的 key,无法录制,故本 PR 使用Refs #30而非Closes,该条验收仍留在 issue 上。