Skip to content

UwcWindowUtil patch code - #5

Merged
hecomi merged 1 commit into
hecomi:masterfrom
nagoya0:feature/desktop_centering
Oct 13, 2018
Merged

hecomi merged 1 commit into
hecomi:masterfrom
nagoya0:feature/desktop_centering

Conversation

@nagoya0

@nagoya0 nagoya0 commented Oct 11, 2018

Copy link
Copy Markdown
Contributor

Hello hecomi.
This is a patch that fixes some bugs in UwcWindowUtil class and lets UwcDesktopLayouter places windows such that a position of windows' parent node matches a center of whole screens.

Reasons:

  1. The existing UwcWindowUtil.ConvertDesktopCoordToUnityPosition() only aligns each window center in the Y-direction, but doesn't align center in the X-direction.
  2. It is incorrect to use Screen.height in the calculating the value of unityY in UwcWindowUtil.ConvertDesktopCoordToUnityPosition(). Should use the height of the entire desktop instead of the height of the destination screen.

…' parent node matches a center of whole screens.
@nagoya0

nagoya0 commented Oct 11, 2018

Copy link
Copy Markdown
Contributor Author

あまりコアでないところかもしれませんが、修正コードを書いてみたのでよろしければご査収下さい😃

@hecomi
hecomi merged commit 2660bca into hecomi:master Oct 13, 2018
@nagoya0
nagoya0 deleted the feature/desktop_centering branch October 15, 2018 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants