Repository navigation
Fix read data stability in axi_lite_register_file - #232
Merged
Merged
Conversation
Also add note on why we don't make a release. Closes hdl-modules#231.
LukasVik
force-pushed
the
fix/stalled-read-data
branch
from
October 17, 2026 03:21
74cca14 to
77f743d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardware status changes could alter unaccepted AXI-Lite read responses. We hold selected values from response validity through completion, preserving handshake and read pulse timing.
New regression covers both hardware-driven register modes, backpressure, read pulses and updated status rereads. Original RTL fails in GHDL and NVC. Both pass six reported reproducer cases and eleven
tb_axi_lite_register_filetests with the fix. File-format and copyright checks pass. GHDL synthesizes the existing wrapper with and without reset. Vivado implementation, timing and resource baselines weren't checked.Fixes #231
— ChipLab