Skip to content

feat: web page of a deal card with the assistant panel - #37

Merged
hawkxdev merged 2 commits into
mainfrom
opencode/issue27-20260929190456
Sep 29, 2026
Merged

hawkxdev merged 2 commits into
mainfrom
opencode/issue27-20260929190456

Conversation

@opencode-agent

@opencode-agent opencode-agent Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

What changed

The web page shows a deal card, conversation and assistant panel. A customer message calls POST /api/suggest; the manager can insert the complete suggested reply into the chat input and add it locally. Labels follow the knowledge-base language. GET / returns the static HTML with only its root language changed.

How verified

All six commands passed on commit be028811bd:

  • uv sync --locked: 35 packages installed from the offline cache.
  • uv run ruff check .: all checks passed.
  • uv run ruff format --check .: 52 files already formatted.
  • uv run mypy .: no issues in 36 source files.
  • uv run pytest --cov: 208 passed; coverage 99.56%.
  • uv run python scripts/check_conventions.py: 36 files, 0 violations.

Each new test has a defect no other test catches:

Test Independently reproduced defect
test_page_changes_only_the_language Restrict rendering to English and Russian, incorrectly replacing the valid de language with English
test_page_fails_before_the_application_started Remove the page startup guard, leaking AttributeError instead of the required RuntimeError

Both mutations failed only their named test; the restored full suite passed.

MCP Playwright executed the actual page in Russian and English with the service and a fake model. Verified loading, reply and product hint, all checks, disclaimer state, token usage, retry reporting and provider error. Insertion copied the entire displayed reply without sending it. Adding a manager message also issued no request. Both layouts fit 1280x720 without page scrolling; no JavaScript exceptions occurred.

Out of scope

The issue assigns browser acceptance to the lead and forbids a new dependency, so no browser runner is added to CI. Real-provider evaluation remains separate. The existing suggest-route startup branch remains uncovered.

Closes #27

Co-authored-by: hawkxdev <hawkxdev@users.noreply.github.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be028811bd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/reply_assistant/static/index.html Resolved
@hawkxdev hawkxdev changed the title All checks pass; web page ready for PR #27. feat: web page of a deal card with the assistant panel Sep 29, 2026
@hawkxdev hawkxdev added the agent-authored Pull request opened by an agent label Sep 29, 2026

@hawkxdev hawkxdev left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified all six checks, both unique test defects, and the Russian and English browser flows including reply insertion without sending. The issue acceptance criteria are met.

@hawkxdev
hawkxdev merged commit 2d2ed43 into main Sep 29, 2026
5 checks passed
@hawkxdev
hawkxdev deleted the opencode/issue27-20260929190456 branch September 29, 2026 19:51
hawkxdev added a commit that referenced this pull request Oct 8, 2026
Co-authored-by: hawkxdev <hawkxdev@users.noreply.github.com>
Co-authored-by: Sergey Sokolkin <hawkxdev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-authored Pull request opened by an agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: web page of a deal card with the assistant panel

1 participant