Name the single build of a series without YJIT plainly - #10
Merged
Merged
Conversation
Series with `yjit: false` (1.8 through 3.1) have one build per target, and it was released as ruby-VERSION.TARGET.no_yjit.tar.gz. mise only ever asks for ruby-VERSION.TARGET.tar.gz, so it never found a precompiled tarball for those versions and compiled from source. The .no_yjit suffix now only distinguishes the two variants of a series that has both; a series without YJIT names its one artifact plainly, whichever flag bin/package was given. Claude-Session: https://claude.ai/code/session_01KeNcsk8V24YRXGfD2HwDZY
excid3
force-pushed
the
plain-name-without-yjit
branch
from
September 9, 2026 19:03
28892fd to
8cc2d50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Series with
yjit: false(1.8 through 3.1, per #3) have one build per target, released asruby-VERSION.TARGET.no_yjit.tar.gz. mise's Ruby plugin only ever looks forruby-VERSION.TARGET.tar.gzin a release, so for every Ruby older than 3.2 it finds no precompiled asset here and falls back to compiling from source. That defeats the point of this repo for the Hatchbox servers that need those versions.Change
bin/packagenames the artifactruby-VERSION.TARGET.tar.gzwhenever the series has no YJIT, regardless of the--yjit/--no-yjitflag: the.no_yjitsuffix only exists to tell apart the two variants of a series that has both. Series with YJIT are unchanged. The build workflow needs no change (it still passes--no-yjitfor those series; only the output file name differs). README and CLAUDE.md updated.Rolling it out
package.rbalters their build fingerprint, so dispatching them (or letting Release New Versions do it) rebuilds them; before Skip rebuilds whose inputs have not changed聽#9, any dispatch rebuilds..no_yjitasset until the rebuild publishes, then drops it as a stale asset. Revision releases keep whatever name they were built with..no_yjitname for those versions by hand must switch to the plain name.Verification
Ruby syntax and rubocop pass on
package.rb; the workflow YAML parses. The change is a one-line naming rule, so I did not run a full local build; the first rebuild of an old series after merge is the real test.https://claude.ai/code/session_01KeNcsk8V24YRXGfD2HwDZY