feat(sidebar): multi-project session list union + expand mode enum - #306
Merged
Merged
Conversation
…839)
Change A: sessionListDirectories() always unions opened + server-registered
projects (no early-return shortcut), so sessions from all historical projects
appear regardless of which project is currently open.
Change B (app side): replace autoExpand boolean with mode enum
("none" | "expand" | "reset") across notifyProjectSelected, session open,
and project-selector callsites.
- helpers.ts: union rewrite + dedup + empty-entry filter
- helpers.test.ts: 4 new tests (union, server-only, dedup, empty filter)
- amicode-workspace-projects.ts: notifyProjectSelected(path, mode) signature
- session.tsx: session open sends "expand"
- session-composer-controls.ts: project selector sends "reset"
Companion to harmoniqs/amicode#839.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jeonghun-jj-lee
force-pushed
the
local/amicode
branch
from
September 6, 2026 22:21
5d7190a to
a904877
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fork-side changes for harmoniqs/amicode#839 — multi-project session experience.
Change A — session list union
sessionListDirectories()always unions opened + server-registered projects (removed the early-return shortcut). Sessions from all historical projects now appear regardless of which project is currently open.helpers.ts: union rewrite with dedup + empty-entry filterhelpers.test.ts: 4 new tests (union, server-only, dedup, empty filter)Change B (app side) — expand mode enum
Replace
autoExpand: booleanwithmode: "none" | "expand" | "reset"across the notification layer:amicode-workspace-projects.ts:notifyProjectSelected(path, mode)signature +ActiveProjectModetype exportamicode-workspace-projects.test.ts: updated to match new APIsession.tsx: session open sends"expand"session-composer-controls.ts: project selector sends"reset"Test results
helpers.test.ts: 29/29 passamicode-workspace-projects.test.ts: 9/9 passCompanion to harmoniqs/amicode#841.