Skip to content

fix(agents): mode cards load their mode-protocol skill at kickoff (#989) - #990

Draft
aarontrowbridge wants to merge 2 commits into
mainfrom
989-director-mode-cards-load-only-director-core-at-kickoff-wire-in-the-modes-own-protocol-skill
Draft

fix(agents): mode cards load their mode-protocol skill at kickoff (#989)#990
aarontrowbridge wants to merge 2 commits into
mainfrom
989-director-mode-cards-load-only-director-core-at-kickoff-wire-in-the-modes-own-protocol-skill

Conversation

@aarontrowbridge

Copy link
Copy Markdown
Member

Important

Problem — Both director mode cards said "First action (kickoff or resume): invoke the director-core skill and follow it" and never named the mode's own protocol skill. The spine is engine-neutral and explicitly "never a replacement" for the mode's binding — the spec-gate mechanics, roles table, probe/experiment boundary, and checkout-registry rules live in the mode skill. Observed failure (2026-09-10, a research-mode pickup): the director loaded director-core only, treated the spine as sufficient, and skipped the mode protocol.

Approach — Each card's directive now requires invoking BOTH skills (the spine first, then the mode skill — research for research mode, autodev for dev mode) before acting on the loop, and a new mode-cards floor test pins the pairing per card so the suite is the contract.

Acceptance Criteria

  • Each mode card's first-action directive names both director-core and its own mode skill, as required first actions before acting on the loop
  • The mode-cards test asserts the pairing per card (research → research, dev → autodev)
  • CI green

Verification

  • npx vitest run test/mode_cards.test.ts19/19 pass locally (17 existing + 2 new pairing tests)
  • pnpm --filter amicode test — the mode-cards suite is green; the branch carries pre-existing red in the overlay/auth/wiring files (verified identical failures with this PR's changes stashed — overlay_known_fixes_964, editable_diffs_wiring, prompt_input_design_placeholder_964, auth-mode seams). Not addressed here; flagged in the issue.

Closes #989

…t just director-core (#989)

Both director cards' first-action directive named only the engine-neutral
spine skill; the mode's own binding (spec-gate mechanics, roles,
probe/experiment boundary) was never invoked — observed cutting the corner
in a 2026-09-10 research pickup. The directive now requires BOTH skills, in
order, and a mode-cards floor test pins the pairing per card.
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Director mode cards load only director-core at kickoff — wire in the mode's own protocol skill

1 participant