fix(agents): mode cards load their mode-protocol skill at kickoff (#989) - #990
Draft
aarontrowbridge wants to merge 2 commits into
Conversation
…t just director-core (#989) Both director cards' first-action directive named only the engine-neutral spine skill; the mode's own binding (spec-gate mechanics, roles, probe/experiment boundary) was never invoked — observed cutting the corner in a 2026-09-10 research pickup. The directive now requires BOTH skills, in order, and a mode-cards floor test pins the pairing per card.
Open
3 tasks
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…cards (AC9 parity, #989)
Draft
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Problem — Both director mode cards said "First action (kickoff or resume): invoke the
director-coreskill and follow it" and never named the mode's own protocol skill. The spine is engine-neutral and explicitly "never a replacement" for the mode's binding — the spec-gate mechanics, roles table, probe/experiment boundary, and checkout-registry rules live in the mode skill. Observed failure (2026-09-10, a research-mode pickup): the director loaded director-core only, treated the spine as sufficient, and skipped the mode protocol.Approach — Each card's directive now requires invoking BOTH skills (the spine first, then the mode skill —
researchfor research mode,autodevfor dev mode) before acting on the loop, and a new mode-cards floor test pins the pairing per card so the suite is the contract.Acceptance Criteria
director-coreand its own mode skill, as required first actions before acting on the loopresearch, dev →autodev)Verification
npx vitest run test/mode_cards.test.ts— 19/19 pass locally (17 existing + 2 new pairing tests)pnpm --filter amicode test— the mode-cards suite is green; the branch carries pre-existing red in the overlay/auth/wiring files (verified identical failures with this PR's changes stashed —overlay_known_fixes_964,editable_diffs_wiring,prompt_input_design_placeholder_964, auth-mode seams). Not addressed here; flagged in the issue.Closes #989