Port the fork UI patch stack to the app overlay: the yellow-chunks grammar (#853) - #954
Merged
Conversation
…mpt bubble's chip, and the bubble lock as a WAAPI merge Port of fork amico/yellow-chunks-on-21 8c91b45fa to the app overlay (#853). The overlay's target files are byte-identical to the fork base the commit was written against (d161eb0c), so the diff rides verbatim: the answer renders with the --prompt-bubble-* tokens right-aligned to the user's side; the sticky bubble drops the YOU label; hand-offs merge via a 240ms WAAPI pass (chip element persists — remount + CSS entrance strobed under smooth scrolling, tried and reverted same day on the fork). Refs #853
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Port of fork amico/yellow-chunks-on-21 6dac9ce04 to the overlay (#853). Edited-files rows show per-file tokens with summed ±, Explored rows show file/pattern/dir tokens with repeat counts, shell rows surface the failure count. Pure docket helpers; dropdowns unchanged (row = summary, dropdown = detail). Counts remain as the pending fallback. Re-homed in the port: docket.ts lives beside edit-row.ts in the ui package (same import seam, ./edit-row relative) with a getFilename inline — no cross-package imports, so the extension vitest lane runs it headless; the re-export shim follows the amicode-shell-row pattern. Refs #853
Port of fork amico/yellow-chunks-on-21 1bd3ae7d7 to the overlay (#853). Full-bleed across the fragment gutters, quiet layer-02 ground in both schemes (shiki tokens stay readable), language label top-right via attr(), copy button keeps its corner. Scoped to prose fragments; tool-output code keeps the inline treatment. Shell-kind's nested box explicitly silenced. Refs #853
…erts to a dark box with the full yellow border Port of fork amico/yellow-chunks-on-21 dc116cd6c + 99cb3f93d, with the 1e2e44b66 revert's recording (net): on LIGHT the user's words are the solid yellow chip — --accent fill, --accent-ink, the ink border (--accent-edge-ink; yellow can't define itself on the near-white ground). On DARK the chip inverts into a layer-01 dark box with the FULL-strength yellow border — one step louder than the assistant fragments' --accent-edge hairline — under base ink. The sticky ghost bubble carries the same tokens + edge (--prompt-bubble-edge, width kept so geometry never shifts between schemes). The prose fragments' own yellow-edge pass (048a11ab3) was reverted the same day on the fork — the fragments stay on the theme hairline; the recording comment lands in the section docs. (fe6eac6b1, the section-transition chunking, was resolved away by the fork's own merge f3aad3cc4 — the heading-anchored segmentation the overlay already carries is the live design; nothing to port there.) Refs #853
Port of fork amico/yellow-chunks-on-21 85d3eaf04 to the overlay (#853). Expanded dropdowns: read and edit rows carry clickable file targets (icon + mono name, full path tooltip, opens in the editor); shell rows gain a status dot (running pulse / error / done), the $ prompt, wall duration, exit code when nonzero, and the tool's one-line output preview. Pure shellRowDetail helper; docket rows unchanged at the top level. Refs #853
…ash registration The docket and shellRowDetail helpers under the extension vitest lane (the #848/#859/#862 headless pattern — the repo's runner, never bun), covering the fork's full test cases, plus CSS-grammar regression guards for the slab / docket slots / yellow answer chip / per-scheme prompt-bubble seating / shell command anatomy (the #349 deletion bug class). Manifest hashes registered for all 8 edited overlay files (the #848 gate); drift gate PASS. Refs #853
…ault token The fork's docket CSS never had a [data-kind="file"] selector (files are the default token kind; dir/pattern/more carry the data-kind). Assert the real grammar: the icon slot and the more-token. Refs #853
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports the yellow-chunks patch stack to the app overlay — the #853 scope that remains after S2 (posture indicator, #864) and S1 (agent_order, #862) landed.
A scoping discovery shaped the port: the issue's "10 commits" range is 9 content commits + the merge f3aad3cc4. Of the two pre-merge commits, the fork's own merge resolved one away: fe6eac6b1 (section-transition chunking) was NOT carried — the heading-anchored segmentation (which the overlay already has, byte-identical to the yellow-chunks tip) is the live design. dc116cd6c (the base yellow chip) DID land and was missing from the overlay. The port is therefore 8 content commits' worth of design.
The overlay's target files were byte-identical to the fork base (d161eb0c) the stack was written against, so the diffs ride nearly verbatim — re-homed only where the port demands (docket → the ui package beside edit-row.ts; tests → the extension vitest lane).
The grammar (commit 1:1 with the fork's design)
--prompt-bubble-edge: ink border on light, transparent on dark); the sticky ghost bubble carries the same tokens.--prompt-bubble-*tokens right-aligned to the user's side; the sticky bubble drops the YOU label; hand-offs merge via a 240ms WAAPI pass (element persists, honors prefers-reduced-motion).Tests (the overlay's headless pattern — #848/#859/#862 precedent)
packages/extension/test/yellow_chunks_853.test.ts(18 tests): the full fork test cases for the docket helpers andshellRowDetail, plus CSS-grammar regression guards for the slab / docket slots / yellow answer chip / per-scheme bubble seating / shell command anatomy (the #349 deletion bug class).Gates
pnpm run typecheckclean; extension vitest: 3106 passed — pre-existing local failures only (terminal ×2 fails on clean main too; cli_gate ×1 is partial-bin residue in the worktree, skips on pristine CI)Refs #853