Skip to content

chore: pin opencode v1.18.29-amicode.27 - #950

Closed
jack-champagne wants to merge 1 commit into
mainfrom
pin-count-label-fix
Closed

chore: pin opencode v1.18.29-amicode.27#950
jack-champagne wants to merge 1 commit into
mainfrom
pin-count-label-fix

Conversation

@jack-champagne

@jack-champagne jack-champagne commented Sep 10, 2026

Copy link
Copy Markdown
Member

Summary\n- bump the release line to 0.3.5\n- pin the OpenCode UI crash fix in v1.18.29-amicode.27\n\n## Verification\n-

amicode@0.3.5 test /home/jack/repos/harmoniqs/amicode-pin-count-label-fix/packages/extension
vitest run --passWithNoTests --exclude '/slow/' test/opencode_dev.test.ts test/opencode_binary.test.ts test/release_workflow.test.ts

RUN v2.1.9 /home/jack/repos/harmoniqs/amicode-pin-count-label-fix/packages/extension

✓ test/release_workflow.test.ts (1 test) 3ms
✓ test/opencode_binary.test.ts (12 tests) 11ms
✓ test/opencode_dev.test.ts (12 tests) 263ms

Test Files 3 passed (3)
Tests 25 passed (25)
Start at 01:03:08
Duration 602ms (transform 75ms, setup 0ms, collect 104ms, tests 276ms, environment 0ms, prepare 179ms)\n\nThe full suite has 13 existing failures on current main, unrelated to this two-file pin: developer-tools cleanup, skill-root fixtures, and editable-diff styling.

Summary by CodeRabbit

  • Chores
    • Updated the extension package to version 0.3.5.
    • Updated release metadata and platform checksums for the bundled release.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 80cde8a7-cb76-4d9a-9f1a-7ea99f57cc07

📥 Commits

Reviewing files that changed from the base of the PR and between 68ffcd9 and 993237b.

📒 Files selected for processing (2)
  • packages/extension/opencode.lock.json
  • packages/extension/package.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The extension package version changed to 0.3.5. The lock metadata now references release v1.18.29-amicode.27 with updated commit and platform checksums.

Changes

Extension release

Layer / File(s) Summary
Update extension release metadata
packages/extension/package.json, packages/extension/opencode.lock.json
The extension version changed from 0.3.4 to 0.3.5. The lock file now uses the new release tag, commit reference, and platform checksums.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: aarontrowbridge, jeonghun-jj-lee, rchari1

Merge Risk: ⚪ Minimal · up to 99323

This release updates the extension version and pins the OpenCode crash fix with updated platform checksums. The release metadata is validated during packaging, with no current merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the version bump and pin change and includes targeted test results. It omits the required Related Issue, Type of Change, and Manual Testing Notes sections, and it does not use… Add a linked issue under Related Issue, select the applicable Type of Change, describe any manual testing or state that none was performed, and complete the required verification checklist. Keep the existing targeted test results and docume…
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary change: pinning OpenCode to v1.18.29-amicode.27. It is concise and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the version bump and pin change and includes targeted test results. It omits the required Related Issue, Type of Change, and Manual Testing Notes sections, and it does not use the required verification checklist.

Resolution

Add a linked issue under Related Issue, select the applicable Type of Change, describe any manual testing or state that none was performed, and complete the required verification checklist. Keep the existing targeted test results and document the unrelated full-suite failures.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pin-count-label-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jack-champagne

Copy link
Copy Markdown
Member Author

Superseded — closing.

Two things happened after this was opened:

  1. chore(opencode): pin v1.18.29-amicode.30 #968 already pinned further, and merged. main is now on v1.18.29-amicode.30 (merged 19:46 UTC today), past the .27 this PR targets. This PR's diff (opencode.lock.json + package.json version, 2 files) is now moot and it's showing CONFLICTING against current main.

  2. More importantly, the pin bump was never going to fix the crash this PR set out to fix. The tool-count-label.tsx TypeError: Cannot read properties of undefined (reading 'startsWith') doesn't come from the vendored engine build — it comes from amicode's own overlay twin of that file under packages/app-bundle/overlay/, which is a separately-committed copy that only updates via an explicit overlay-sync/materialize step, not via the engine pin alone. Bumping the pin (to .27, or now .30) leaves that twin untouched, which is exactly why the last few 0.3.5 alphas (through alpha.5, cut 20:04 UTC today) still ship the unguarded version.

The actual fix landed as #988 (fixes #987), which patches the overlay twin directly with the missing-translation guard and ships a regression test that reproduces this exact crash. Picking that up instead — it's a smaller, targeted, single-concern change with green CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant