fix: workspace-projects bridge message lost — project selector falls back to stock opencode - #871
Merged
jeonghun-jj-lee merged 3 commits intoSep 7, 2026
Conversation
…870) The workspace-projects bridge message was registered as a one-shot onAppReady callback, which drains on the first app-ready and never fires again. This broke the project selector on new sessions after the M3 cutover shifted activation timing. - Add onAppReadyPersistent(): callbacks that fire on EVERY app-ready (the one-shot contract is unchanged for other consumers) - Add ChatPanel.postToAll(): broadcasts to every live panel, not just the primary singleton (fixes side-by-side sessions) - Wire pushWorkspaceProjects as persistent + broadcast Closes #870 (AC1, AC2, AC3)
jeonghun-jj-lee
added
bug
4 tasks
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jeonghun-jj-lee
marked this pull request as ready for review
September 7, 2026 03:54
… + dedup (#870) Three interacting bugs silently killed the #841 expand/scroll-on-session-change: 1. renderRoots replayed pendingActiveProject with hardcoded mode='none' (sidebar_webview.ts:1010), permanently downgrading every session-change expand to highlight-only. Fix: replay with the STORED mode. 2. The dedup guard (sidebar_view.ts:444) checked path only, so a rescue attempt with the same path but mode='expand' was blocked after the 'none' replay. Fix: dedup on (path, mode) together. 3. The sidebar replay on webview resolve (sidebar_view.ts:416) omitted the mode field entirely, defaulting to 'reset' (which collapses other folders). Fix: store and replay the mode. The #841 code was fully intact — nothing was overwritten by subsequent merges. The bug was a timing interaction present from merge day.
Closed
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #870
What
The
workspace-projectsbridge message was registered as a one-shotonAppReadycallback, which drains on the firstapp-readyand never fires again. After the M3 cutover shifted activation timing, the push no longer reliably delivered — the app fell back to engine-native project discovery (no type grouping, no Research/Dev labels).How
onAppReadyPersistent()— a new callback mechanism onChatPanelthat fires on EVERYapp-readymessage (the existing one-shot contract is unchanged for other consumers like onboarding greeting)ChatPanel.postToAll()— broadcasts a message to every live chat panel (primary + side-by-side), replacing thepeek().postMessagepattern that only reached the singletonpushWorkspaceProjectswired as persistent + broadcastTesting
chat_panel.test.tscovering all 4 ACs (persistent handler survives drain, fires on repeat, broadcast reaches multiple panels, workspace-folder changes re-push)