S1a rev-3 amendment: build returns to the picker — plan · build · develop · research

[aarontrowbridge]

Closes #868 (spec-20260907-011500 D1 rev 3 — the amended spec is the contract).

What lands

The config default. agent_order becomes ["plan", "build", "develop", "research"] (buildOpencodeConfigContent, #305's field, honored APP-SIDE by the overlay's picker sort) — the four-name fixed order, pinned by the extension test.

The named tile + the default marker. build renders under its own name marked default — the S1 implied-absent marker is replaced, not the render shape: isImpliedAgent/impliedAgent → isDefaultAgent/markedAgent, the AgentPickerOption field implied → default, and the i18n key agent.picker.implied → agent.picker.default with real "default" translations across all 18 locales (en + 17). build's id was never renamed — the alias/rename tests are untouched except for comment honesty.

The tests. The S1 implied-marker assertions become default-marker assertions; the picker-sort suite gains the four-name order pin (the shipped agent_order sorts plan → build → develop → research); the alias/rename tests unchanged. The plan-exit recommendation (landed S2, posture_recommendation.ts) is pinned by a property test to NEVER target build across every shape split × executor hint — build is the resting state, not a recommendation target.

The gates. Overlay manifest hashes refreshed for exactly the 22 touched overlay files (surgical — not a full manifest refresh, whose stale upstream cache would churn unrelated classifications); drift gate PASS (596 files, committed overlay vs manifest); i18n parity ×18 with placeholder preservation.

Verification (run on the branch)

• pnpm -r run typecheck — clean (schema, amico-run, extension).
• pnpm -r run test — schema 246 green; amico-run 1 pre-existing failure (agent_spawn.test.ts $AMICO_AGENT_CONFIG_DIR env leak — machine-local env, reproduced on clean main); extension 2 pre-existing failures (terminal.test.ts ×2 — env-local, reproduced on clean main; editable_diffs_wiring.test.ts ×2 flaked dirty in the same run and passes on clean main — the chore(test): overlay-sync test applies to the local fork checkout's committed tree — point it at a temp tree #842 dirt struck mid-suite and was restored before commit).
• Overlay picker + i18n suites (bun:test imports) run under vitest with a bun:test→vitest alias (config outside the repo): 19/19 — picker 17 (incl. the new four-name pin) + app/ui parity ×18 locales, old key gone everywhere.
• Drift gate: drift_gate.mjs PASS — committed overlay verified against the manifest (596 files). The full gate (fork re-derivation) is env-broken on this machine (the fork clone lacks the pinned tag; the v1.18.29 archive cache is absent) — pre-existing on clean main, CI runs the committed-state lane.
• The chore(test): overlay-sync test applies to the local fork checkout's committed tree — point it at a temp tree #842 app-bundle dirt hazard struck mid-verification (262 files of fork-content dirt); the tree was restored and the committed diff audited — HEAD is clean, the commit carries only the 30 intended files (+128/−96).

Refs #868 · spec-20260907-011500 D1 rev 3 · amends #862 (S1)

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}