feat: SEAM 2 — regime rules as recommendations, the five-knob priors table (#699) - #701
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
aarontrowbridge
added a commit
that referenced
this pull request
Sep 1, 2026
…e follow-through on #701) origin/main advanced mid-slice with #701 (SEAM 2 — regime priors): the plugin's amicode_recommend gained the composed query (ledger priors ∪ regime priors via serveRecommendations, platform family scoped from the recorded system), the new audit action (auditRegimePriorApplications — the off-profile sensor with the census-staleness check), the current_census arg, and the four-action description. That body is now in the core VERBATIM (byte-identical to main's plugin text; the two sibling specifiers re-based to ../opencode-plugin/), so both transports serve it: the plugin adapter projects it (behavioral reference — main's own scripts/plugin_exercise.ts passes against the shim), and the MCP server serves it under the bare wire name (recommend). The conflict discipline: rebase resolved opencode-plugin/amicode_tools.ts as the retirement adapter (ours) — main's plugin content lives on through the core; regime_priors.ts/.json, their tests, plugin_exercise.ts, and the packaging list arrived from main untouched (diff vs main on the plugin dir = exactly the four type-fix files from the extraction).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #699. Part of #679 (the codesign PRD). The Aug-16 campaign core finding becomes recommendations: a committed priors table for the five named calibration knobs (tr_frac, β, y_goal, GLS weighting, min_contrast), keyed by platform family, provenance-stamped with the census (2026-08-31, 12 profiles: 4 spin / 4 transmon / 4 atom) + the public-scale caveat riding every entry, served through the amico_recommend query path (the one recommendation surface — ledger recs keep their cap-to-medium; static priors state confidence explicitly: gls_weighting HIGH from the measurement kinds + PR #36; min_contrast 2.5 HIGH from the #65/#81 + #83/#84 fixture evidence; β and y_goal MEDIUM from the hardware-loop doctrine; tr_frac LOW by design — starting points the flywheel sharpens). The audit (a new amico_recommend action) is F2 sensor: FAILS an off-scope prior without the caveat, PASSES with it, surfaces census staleness. A1 leak guard mechanical: no census-vendor name anywhere (family keying only — and two public-paper vendor designations hand-struck beyond what the guard could catch), no drift-scale/trust-geometry/crossover fields, internal tier unreachable by construction. The dynamic-census contract stated in-schema; regeneration wiring to the freshness cadence = the named follow-up. Evidence chains per value in the table sources. Director gates: 1880 passed + the 3 documented pre-existing env failures, typecheck clean; plugin_exercise end-to-end green by cast run. Overlay untouched.