fix(bug-report): carry composer's live model onto bug session (#277) - #597
Merged
aarontrowbridge merged 2 commits intoAug 27, 2026
Conversation
Carry the composer's live model selection (provider/model/variant)
across the app→extension command bridge and onto the report-a-bug
arming turn, with precedence over the configured default.
- App (report-bug.ts): include model payload from live selection;
ReportBugButton now accepts model prop and PromptInputV2Composer
supplies liveModel() from controller.model.selection (current +
variant). Payload validated/bounded before postMessage.
- Bridge (chat_bridge.ts): extractReportBugModel already validated;
now forwarded to vscode.commands.executeCommand('amicode.reportBug',
model) only for reportBug — other allowlisted commands remain
payload-free, allowlist size unchanged (10).
- Extension (bug_report.ts, extension.ts): reportBug(liveModel?)
now threads through open() → armSession() with precedence
live → configured default → omit (server resolves). Variant
travels only with live selection; malformed/oversized/absent
never blocks — falls back. Command registration now forwards
optional model arg.
Tests: live honoured, variant honoured, precedence over default,
configured fallback, omit when neither, malformed stripped, absent
tolerated, shape/length validation at bridge, allowlist unchanged.
Related #298 (model picker stale) may share root cause — same
tracked-model plumbing — but not auto-closed; see #277 AC.
Co-authored-by: Amico <amico@harmoniqs.ai>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
aarontrowbridge
marked this pull request as ready for review
August 27, 2026 14:27
aarontrowbridge
deleted the
277-bug-carry-the-composers-live-model-selection-onto-the-bug-session
branch
August 27, 2026 14:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #277 — carry live model selection across bridge, fixes stale-model bug.
report-bug.tsnow includes validated model payload (+ variant) fromPromptInputV2ComposerliveModel();ReportBugButtonaccepts model prop; bounded validationchat_bridge.tsextracts and validatesreportBugModelonly foramicode.reportBug;extension.tsthreads optional model toBugReportManager.reportBug(liveModel?)with precedence live→configured→omitTests: 11 new (bug_report + chat_bridge), precedence + malformed/oversized + variant
Related #298 (model picker stale) noted as potential duplicate — same plumbing may fix, needs separate verification, not auto-closed.
Implements branch 277-bug-carry... from hygiene sweep.