fix(tabs): close tab on double-click (#323) - #584
Closed
aarontrowbridge wants to merge 4 commits into
Closed
aarontrowbridge wants to merge 4 commits into
aarontrowbridge wants to merge 4 commits into
Conversation
Double-clicking a session or draft tab now closes it via the existing close-tab handler (props.onClose / closeTab), matching standard tab UX and VS Code's native behavior. Adds onDblClick to TabNavItem (guarded by editing()) and DraftTabItem containers, reusing the same closeTab logic as the close button and middle-click. Adds e2e regression tab-dblclick-close.spec.ts and vitest source-check titlebar_dblclick_close.test.ts (RED→GREEN).
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #323
Double-clicking a session or draft tab now closes it via the existing close-tab handler, matching standard tab UX (VS Code native).
Tests