fix: free-form questions render a visible text input (#349) - #361
Merged
Merged
Conversation
The opencode commit c1e4862d (file-reference resolution, PR #143) accidentally deleted the [data-slot="question-text-form"] CSS rules that made the kind:"text" question textarea visible (border, background, min-height). This lock bump pins the fix (opencode PR #191). Source set to 'local' pending the next opencode release tag — once harmoniqs/opencode#191 merges and a release is cut, bump back to source:'release' with the new tag. Closes #349
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe opencode lockfile now uses a local source reference, a new commit, and an updated Darwin ARM64 checksum. ChangesOpencode lock update
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the agent asks a free-form question (
kind: "text"), no textarea appears for the user to type their answer. The question text and footer buttons render, but the input area is invisible.Root cause
The opencode commit c1e4862d (PR #143, file-reference resolution) accidentally deleted the
[data-slot="question-text-form"]CSS rules that had been added by PR #124 (fix opencode#121). These rules gave the text-card textarea its:Without them, the textarea inherits the choice-card's transparent/borderless custom-input style — invisible.
Fix
Restores the deleted CSS in the opencode engine (harmoniqs/opencode#191) and bumps the vendored binary pin to include it. A regression test in the opencode repo asserts the selectors remain present.
Dependencies
Once that PR merges and a release is cut, this lock should be bumped from
source:"local"tosource:"release"with the new tag.Testing
bun test packages/session-ui/src/components/message-part-css.test.ts— 4/4 passbun test packages/app/src/pages/session/composer/session-question-dock.helpers.test.ts— 6/6 passvitest run test/opencode_config.test.ts— 24/24 pass--version→ 1.18.10)Closes #349
Summary by CodeRabbit