Skip to content

chore(fleet): re-home the profile/skill tree to the armonissima vault; multi-root skill validation - #256

Closed
aarontrowbridge wants to merge 1 commit into
chore/skills-into-amicodefrom
chore/skills-to-armonissima
Closed

aarontrowbridge wants to merge 1 commit into
chore/skills-into-amicodefrom
chore/skills-to-armonissima

Conversation

@aarontrowbridge

Copy link
Copy Markdown
Member

What

The internal-content half of the amico-plugin dissolution (stacked on #255, the public half). profiles/, gates/, and the 28 internal skills now live in the armonissima team vault (pushed as armonissima@3d78491); mount presence is the eligibility proof — the same pattern as the retired plugin checkout, carried by the vault sync instead of a git clone.

The real change: multi-root skill validation in profile_verb

The shipped fleet presets compose both skill tiers — e.g. researcher stages amico-vault + hypothesis-review (public) alongside internal skills. A single --skills-dir cannot name two roots, and the old default (~/harmoniqs/amico-plugin/profiles) never existed on main, which is why the 12 shipped-preset tests were permanent skips.

  • --skills-dir is now repeatable; any explicit flag(s) replace the defaults.
  • Skill existence + surface: is a union check across roots, first-hit wins (matching the library resolver).
  • Defaults: the vault's skills/ + the extension's in-repo public library when resolvable from the installed bundle layout (bin/dist/amico.js../../skills); self-disables in dev/CI.

Result: the 12 preset tests run for the first time and pass — amico-run suite is 952 passed / 0 skipped (was 940 + 12 skips).

Canonicity sweep

The mounts resolver (amico-run/src/mounts.ts) and mount_store.ts were ported from the Claude session-start hook with a "parity oracle" relationship. The hook is retired with the plugin repo — the TS ports are now declared canonical and the fixtures are the spec. profile_verb's lint-port comments re-point at the vault tree; lens_registry's deviation note resolves to "the design"; verbs.ts / ledger_dispatch.ts comments updated.

Verification

  • amico-run: 952 passed / 0 skipped; extension: 868 passed / 1 skipped; both typechecks clean.
  • The shipped armonissima presets (researcher, experimenter, engineer, librarian-insight, dreamer, default) resolve in both dispatch and spool-up modes against the two-root union.

Follow-ups

  • wip/fleet-profiles on amico-plugin should die unmerged — its content landed in the vault.
  • Phase 3: plugin tombstone + archive after soak; vault-sync daemon sources move to the amico repo.

…; multi-root skill validation

The internal content half of the amico-plugin dissolution (the public half is
PR #255): profiles/, gates/, and the internal skill library now live in the
armonissima team vault (pushed as armonissima@3d78491); mount presence is the
eligibility proof, same pattern as the retired plugin checkout.

profile_verb: the shipped fleet presets compose BOTH tiers (researcher names
amico-vault + hypothesis-review — public), and a single --skills-dir cannot
name two roots. --skills-dir is now REPEATABLE; skill existence/surface is a
union check across roots (first-hit wins, matching the library resolver);
defaults = the vault skills dir + the extension's in-repo public library when
resolvable from the installed bundle layout (bin/dist -> ../../skills). This
lets the 12 long-skipped shipped-preset tests RUN for the first time (the old
default root never existed on main) — they pass.

Canonicity sweep: the mounts resolver + mount_store were ported from the
Claude session-start hook; with the hook retired, the TS ports are the source
of truth and the fixtures are the spec. profile_verb's lint-port comments
re-point at the vault tree; lens_registry's deviation note resolves to "the
design"; verbs/ledger_dispatch comments updated.

Verified: amico-run suite 952 passed / 0 skipped (was 940 + 12 skips);
extension suite 868 passed; typecheck clean.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant