Add side-by-side chat sessions (Amicode: New Chat) - #238
Merged
Merged
Conversation
ChatPanel goes from singleton to multi-instance registry: openOrReveal keeps primary semantics (auto-open, Open Chat), and a new openNew spawns an additional editor tab at ViewColumn.Beside pinned to the app's /new-session draft route — each tab owns its conversation over the one opencode server. Tabs title Amicode Chat / Amicode Chat N (lowest free, reused on close). No fork change needed: /new-session exists in the pinned binary (v1.17.3-amicode.12). 5 new tests cover coexistence, reveal isolation, title numbering, Beside column, and auth-token carriage.
- buildChildEnv: denylist OPENCODE / OPENCODE_PID / OPENCODE_SERVER_PASSWORD —
they ride the OPENCODE_ prefix allowance into the child, whose headless run
then resolves the PARENT's session ("Session not found") and dies before the
critic starts. Config vars (OPENCODE_CONFIG_CONTENT/DIR) stay.
- CRITIC_TIMEOUT_MS 120s -> 240s: a frontier review of a full spec measures
~3 min on a free-tier model (178s, 2026-07-31); the 120s ceiling read slow
legitimate answers as failures and silently degraded every review to
approved-mechanical.
- Planner gets its own ceiling (PLANNER_TIMEOUT_MS = 480s): a full gated plan
JSON is a bigger output than a critic pass and measured beyond 240s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
New command Amicode: New Chat (Side by Side) (
amicode.newChat): opens an additional chat editor tab atViewColumn.Beside, pinned to the app's/new-sessiondraft route. Each tab owns its own conversation; all tabs share the one opencode server. Tabs split across editor groups = true side-by-side sessions in one window.How
chat_panel.ts: singleton → multi-instance registry.openOrRevealkeeps primary semantics (auto-open, Open Chat untouched); newopenNewalways spawns a tab. Tab titles:Amicode Chat,Amicode Chat N(lowest free, reused on dispose; existing tabs never retitled).extension.ts: command registration besideopenChatwith the same ready-server snapshot + credential gates.package.json: command contribution ($(add)icon) + activation event./new-sessionexists in the pinned binary (v1.17.3-amicode.12).Tests
5 new cases in
test/chat_panel_sessions.test.ts: panel coexistence, openOrReveal reveal-isolation, title numbering/reuse,Besidecolumn, auth-token carriage on the draft URL. vscode mock gainsViewColumn.Beside.Gates
typecheck clean · fast suite 819/819 · esbuild bundle builds · boot smoke PASS.
Follow-ups (not in this PR)
buildServerSpawnEnvreadsprocess.env.AMICO_PYTHON;opencode_probe.mjsinheritsOPENCODE_SERVER_PASSWORD(boot smoke 401s). Both unrelated to this change.