Repository navigation
feat(sidebar): FLEET header Add-machine + Refresh actions (#1764) - #1765
Merged
jeonghun-jj-lee merged 6 commits intoOct 12, 2026
Merged
jeonghun-jj-lee merged 6 commits into
jeonghun-jj-lee merged 6 commits into
Conversation
added 5 commits
October 11, 2026 22:47
jeonghun-jj-lee
marked this pull request as ready for review
October 12, 2026 03:05
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…rol (#1764) Two review follow-ups to the FLEET header work: - Add machine now routes BOTH standalone and empty section states to /create-a-fleet (no fleet exists yet, so start one); populated, unreachable, and the not-yet-posted case keep /add-fleet-device. Unreachable stays on add-fleet-device because a down host can't be known to be empty. - Remove the per-row focus control (the target-glyph button + its CSS) for now — it did not earn its place in the UI. The focus SUBSYSTEM is kept intact: the focus-machine message/handler, FleetFocusStore, applyFocusRequest, focus-follows-tab, the overlay push, and the focused-row marking all stay, so restoring the control is a re-add. Tests updated accordingly; full fast suite green (5299 passed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1764.
Adds Add machine (+) and Refresh (↻) to the FLEET sidebar header, and routes every fleet chat launch through one exactly-once launcher. A per-row focus control was built and then removed for now on review (see below) — the focus subsystem it drove is retained.
What changed
/create-a-fleet(no fleet exists yet, so start one); populated or unreachable →/add-fleet-device. Unreachable keepsadd-fleet-devicebecause a down host can't be known to be empty.d98e8870): the per-row target-glyph button and its CSS are gone; on review it didn't earn its place in the UI. The focus subsystem is retained intact — thefocus-machinemessage/handler,FleetFocusStore,applyFocusRequest, focus-follows-tab, the overlay push (theonChangewiring from Fleet Studio wiring — W3: wire the fleet focus selector into the sidebar #1451), and the focused-row marking all stay. Restoring the control is a re-add, not a rebuild.CONTEXT.mdgains Machine and Focused machine and a corrected Sidebar entry.No engine/overlay change. New Project / New Environment launch paths untouched (follow-up in the issue).
Gates (run by the director, not self-reported)
5738e1e1d98e8870tsc --noEmit)No
.only/.skip/.todoadded; existing assertions changed only where the issue flips them, plus the two review follow-ups above (empty-fleet routing; focus-control removal and its tests).Needs a human
renderSectionHeader("Fleet", "fleet"), so the actions mount via a sharedmountSectionActionshelper after that call rather than as a third argument.3c7c43d5is red on its own (two pinned tests); fixed in51ff0ad8. Squash-merge recommended (and it collapses the6605b800focus-control add +d98e8870removal into the shipped state).