Repository navigation
test(amico-run): triage-papers named-paper runs pass --papers explicitly — restore main's fast CI (#1703) - #1713
Merged
Conversation
…tly (#1703) The three failing tests gave the verb a named paper with no --papers flag and {} env, silently leaning on the dev machine's real personal mount (~/.amico/vaults) for the intake fallback. CI has no vault, so the verb exited 64 there ('no papers intake resolved') while staying green on any machine that happens to have a vault — the tests were born red in CI (their introducing run 37110536362 failed). Pass --papers explicitly in the named-paper dry-run, below-relevance, and apply cases, with the hermeticity rule inline: ambient vault state is never a test fixture. The curl 404/429 lines in the CI log are hermetic fake-curl stderr from the sota transport tests, not live network — the suite's one live call is already env-gated (AMICO_SOTA_LIVE=1).
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1703. The story, corrected from the issue's framing: the curl 404/429 lines in the CI logs were hermetic fake-curl stderr (sota_papers' anti-laundering fixture prints them deliberately) — no live network involved. The real failure: the three named-paper triage tests silently leaned on the dev machine's personal vault (the --papers fallback resolves ~/.amico/vaults); CI has no vault → the verb's intended exit-64 'the intake is never a guess' → red. Born-red: the introducing PR #1686's own CI failed identically — the tests only ever passed on vault-bearing dev machines. The fix: explicit --papers in the three runs (a construction change, reason inline; fixtures already existed). Verified RED→GREEN under a vault-less HOME (byte-identical to CI), suite 118 files / 2114 passed / 0 failed, typecheck clean. Optional hygiene follow-up noted: a fast-job assertion that no test resolves a real mount, making ambient-vault leaks a CI-visible class.