Repository navigation
feat(extension): the vetted templates ride the MadNLP-default solve surface (#1676) - #1702
Merged
Merged
Conversation
…urface (#1676) DirectTrajOpt 0.11 flipped the no-kwarg solve! default to MadNLP (QualityFunctionUpdate barrier; the #155 restoration audit — 0.99999996 @ 60 iters on the previously-failing seed class), Piccolo 2.2 inherits it. The solve surface follows: - pulse-designer solve.jl: SOLVER = :default (MadNLP) first — solver- agnostic construction, no options struct; the 60-iter budget stays (audit-safe); AMICODE_ITER rides a raw MadNLP.AbstractUserCallback via intermediate_callback, UserCallbackRegular-filtered (restore/robust fire without advancing the counter); explicit RelaxBound (a raw user callback manages its own fixed-variable treatment); :ipopt arm kept verbatim (IpoptOptions + the raw callback channel — Ipopt-only kwarg); version probe bumped to Piccolo 2.2 / DTO 0.11 (the MadNLP default). - pasqal-mis solve.jl: same dual-channel MadNLP construction + the DirectTrajOpt.Callbacks fix (Piccolo.Callbacks was the pre-0.10 re- home — dead since 2.1) + the version probe. - Q74 amended in the contract docs: the AMICODE_ITER channel is backend-native (MadNLP raw user callback / Ipopt raw callback), the Inspector is solver-agnostic; mode-filter note everywhere the ipopt- only fact lived (hub-AGENTS.md, ledger-bridge, solve_template*.jl). - gate solver expectations: backend enum += madnlp (both vendored problemspec schemas, matching the Piccolo 2.2 reflection); omitted- backend hashing + ledger defaults flip ipopt→madnlp (parse.jl parity — the cross-language problem_hash diverged on exactly those specs); MadNLP joins the import-scan support set (authoring DEFAULT_SUPPORT + registry.toml) + the pack corrector integrity refresh.
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closed
2 tasks
…8f209a (v2.2.0) — the byte-verbatim source supersedes the hand-set enum; sidecar pinned to the v2.2.0 commit
…istry-418 @1c6514a (the 2.2.0 emission) + update the oss-variant guard to the 2.2.0 public-kind contract — the demotion made the native integrator tier public (Piccolo's drift.jl in lockstep), PRIVATE_ONLY gains adjoint_robustness, the offered-kind equality assertions replace the dead private-integrator-kinds concept
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1676.
The solve surface rides MadNLP — verified end-to-end through the gate
Mirror-env gate smoke (registry Piccolo 2.2.0 + DTO 0.11.0, the live env untouched):
amico runtier=vetted PASSED including the import scan admittingimport MadNLP— run r20261003-103343Z-81d3: F = 0.9987, 61 AMICODE_ITER + 61 AMICODE_PULSE emits (monotone counters — the mode filter proven), atomic result.toml, 11 iteration frames, FINISHED clean. Bonus live legs: cooperative STOP under MadNLP verified; RelaxBound proven load-bearing — MadNLP's default MakeParameter prunes fixed vars from the solver vector, so the raw user callback must self-manage RelaxBound or the live plot emits zero pulses; the template now does.What landed
SOLVER = :default(MadNLP via the DTO default, no options struct;print_level = 0for the reversed log scale); the:ipoptarm kept verbatim;:altissimountouched; the pasqal-mis template's dead pre-0.10 re-home (Piccolo.Callbacks) fixed in passing. The 60-iter budget stays (audit-safe; head-to-head MadNLP median 0.99958 vs Ipopt 0.99882 on the class).madnlpbackend enum (byte-verbatim from Piccolo 2.2.0's reflection); the TS hashing/exec defaults for OMITTED backends align ipopt→madnlp (restores cross-language hash identity with Piccolo's parse.jl).Suites
extension 3709 tests green (incl. 9 new pins); schema 301 green; amico-run 2107 green on the touched surfaces (the flaky upgrade-* timing tests fail identically on the pristine base — verified by stash).
Director follow-ups (from the return)
The LIVE shipped-env bump recipe is proven in the mirror (Project.toml edits + instantiate; the explicit MadNLP [deps] entry is REQUIRED — transitives don't satisfy
importunder--project) — director-timed against Aaron's live solves. Two pre-existing-broken tier-1 registry templates (Piccolo.Callbacksre-home) noted for a separate release-train slice.