Repository navigation
feat(amico-run): adoption stamping — the feedback loop closes (#1683) - #1694
Merged
Merged
Conversation
…n-keyed idempotent stamps (#1683) Brain flywheel slice 4 (#1679): the feedback loop closes — knowledge USED reaches the claim. An accepted recommend-outcome or a solve-run citation increments the cited claim's applied counter + last_applied and appends ONE applied history entry (the pinned vocabulary, no new event class); statement and status are never touched (adoption is a counter + a date, never a judgment — lifecycle stays slice 5's). - stamp: the callable verb — dry-run default, --apply writes; the citation must resolve into the substrate first (the event exists in the problem's events.jsonl AND is accepted; the run dir exists); re-stamping the same citation is a stamped:false no-op (the citation is the idempotency key, carried in the applied note's fixed convention). - sweep: the nightly backfill — walks every problem workspace's events.jsonl (the ONE machine-readable adoption record that exists today: the recommendation events amicode_recommend appends), pairs accepted outcomes with their propose's provenance refs, resolves refs mechanically against the registry (trailing segment; projection names claims after their cards), stamps; overridden outcomes are named, never stamped; unmatched refs are named skips. Idempotent: re-sweep changes nothing (byte-tested). - pure core in claims.ts (stampAdoption / isStamped / appliedNote / renderStampedNote / resolveClaimRef / planAdoptionSweep); prose below the frontmatter survives a stamp verbatim (renderStampedNote). - fixtures: stamp-registry (2 claims) + sweep-problems (2 event streams, a no-events workspace); solve-run citations have no machine-readable stream yet and ride the stamp verb — the honest seam, documented in the verb.
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1679. Closes #1683. TDD green: 20 new tests (core+verb), claims suites 95/95, typecheck clean.
claims stamp(recommend-outcome | solve-run citations, citation must resolve, dry-run default) +claims sweep(nightly idempotent backfill from the real events.jsonl recommendation records — proposed/outcome paired, overridden named-never-stamped). Event seam documented honestly: no machine-readable solve-run citation stream exists yet — citations ride the stamp verb. Idempotency: second sweep stamped 0, registry md5-identical.