Repository navigation
test(amico-run): sessions-index month assertion follows the seed, not the calendar - #1655
Merged
Merged
Conversation
… the calendar The fixture seeds ses_a1 with updatedDaysAgo: 2 — relative to now — but the assertion compared the index's month section against the CURRENT month. In the first days of each month the two disagree (Oct 1: the seed landed in September) and the test reddened clean main. The expectation now derives from the same 2-days-ago timestamp the seed uses — month-boundary-safe by construction.
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sessions index — regenerationtest seedsses_a1withupdatedDaysAgo: 2(relative tonow) but asserted the index's month section equals the current month — which breaks in the first days of every month. Observed live on 2026-10-01: the suite on clean main went 1-fail withExpected: "2026-10" / Received: "2026-09", reddening CI for every PR this week.The expectation now derives from the same
2 days agotimestamp the seed uses — boundary-safe by construction, no product change.Verification
bun test test/sessions_verb.test.ts— 44 pass / 0 fail (was 1 fail on clean main, reproduced before the fix)bun typecheck— clean. Test-only diff.