Skip to content

fix(amico-run): strategy-brief is a TOP-LEVEL verb — the synthesis seam's documented contract - #1654

Merged
aarontrowbridge merged 2 commits into
mainfrom
opencode/strategy-brief-top-level-verb
Oct 1, 2026
Merged

aarontrowbridge merged 2 commits into
mainfrom
opencode/strategy-brief-top-level-verb

Conversation

@aarontrowbridge

Copy link
Copy Markdown
Member

The weekly-synthesis dispatch dry-run (amicissimo run 36836288143) failed at the invocation seam with `amico: unknown verb "strategy-brief"`: the engine invokes `bun …/src/amico.ts strategy-brief …` (the seam's documented contract since slice 3), but the renderer's dispatch landed only inside `trySubcommand` — reachable via `amico run …`, never at the top level. The router's switch already carries top-level cases for `resolve`/`sandbox`/`estimate` (the same subcommand family); `strategy-brief` was simply never added.

One case line, mirroring the family's pattern exactly.

Verification

  • RED→GREEN: new router test first — `amico strategy-brief` with missing corpus paths must produce the RENDERER's validation error, never the router's unknown-verb error. Red on main, green with the case.
  • `bun test test/amico.test.ts` — 25 pass / 0 fail
  • `bun test` (full package) — 1774 pass / 11 skip / 1 fail; the single failure is `sessions index — regeneration`, pre-existing on clean main (a month-boundary date flake: `updatedDaysAgo: 2` crossed into September on Oct 1 while the test asserts the current month — verified failing on the untouched checkout; separate fix PR incoming)
  • `bun typecheck` — clean

…am's documented contract

The notturno weekly-synthesis engine invokes 'bun …/src/amico.ts
strategy-brief …' — the renderer was wired only into launch's subcommand
table (trySubcommand), so the top-level head fell to the router's
default and the seam died as 'amico: unknown verb "strategy-brief"'
(dry-run 36836288143). Mirrors the resolve/sandbox/estimate pattern:
case 'strategy-brief' → launch(['strategy-brief', …rest]).
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: fbd9957b-1f85-4b5b-ad0a-bd2115a8623c

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aarontrowbridge
aarontrowbridge merged commit f493b6f into main Oct 1, 2026
12 checks passed
@aarontrowbridge
aarontrowbridge deleted the opencode/strategy-brief-top-level-verb branch October 1, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant