Wave: restore #1218 empty-content guard on main (missed Wave 2) - #1237
Closed
jeonghun-jj-lee wants to merge 1 commit into
Closed
jeonghun-jj-lee wants to merge 1 commit into
jeonghun-jj-lee wants to merge 1 commit into
Conversation
…he wave-2 merge (#1236) The wave-2 back-merge of main into dev (dfe3fbe) hand-ported the 568306f reasoning->text conversion but dropped the separate #1218 final guard from provider/transform.ts: msgs = msgs.filter((msg) => !Array.isArray(msg.content) || msg.content.length > 0) This is the last line of defense against a message with content: [] reaching a provider SDK/API — the class of Bedrock session-wedge #1218 closed. dev kept main's transform.test.ts (the 'final empty content guard' describe block still asserts empty-content messages are dropped), so the implementation and its tests were out of sync on dev. The overlay's bun tests aren't run by any CI job (build-binary compiles the overlay but doesn't test it; 'fast' is the extension vitest), so the regression was silent — dev is CI-green with the guard gone. Restores the guard verbatim from main: transform.ts is now byte-identical to origin/main except Aaron's wave-2 provenance comment. manifest.json updated surgically (the single transform.ts content hash); drift_gate.mjs PASS. Co-authored-by: amicode-ci <ci@amicode.local>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave — carry the #1218 guard fix that just missed Wave 2
A micro-Wave graduating exactly one commit from
devtomain:a91c0159(#1236), the restore of the #1218 empty-content final guard.Why
mainneeds itWave 2 (#1232) graduated
dev→mainat 13:19Z. At that momentdevstill carried the wave-2 merge regression — the #1218 final guard (msgs.filter(... content.length > 0)) had been dropped fromprovider/transform.ts. The fix (#1236) landed ondevat 15:14Z, ~2h after Wave 2 sailed. Somaincurrently ships without the guard — exposed to thecontent: []→ provider-SDK Bedrock session-wedge class that #1218 closed.Scope — one clean commit
devis exactlymain + a91c0159; nothing else has diverged since Wave 2. This PR shows that single commit and merges as a zero-conflict fast-forward, convergingmain == dev.transform.ts— guard restored; byte-identical to the pre-Wave-2main, plus the wave-2 provenance comment.manifest.json— the singletransform.tscontent-hash line.drift_gate.mjspassed ondevbefore #1236 merged.Same rule as Wave 2 (which merged as "Merge pull request from harmoniqs/dev"): squashing mints a new SHA and re-orphans
dev's history frommain, breaking the next Wave's fast-forward.Closes the
main-side of the #1218 regression.