Redesign Run Inspector: overlay pulse plot, metrics rail, fidelity≠objective fix - #117
Merged
Merged
Conversation
… rail, fidelity≠objective fix - Pulse plot now overlays all drives on ONE shared time/amplitude axis with a legend, instead of a stack of per-drive panels. Adapts to any run shape: overlay for <=6 drives, small multiples for 7+ (position + labels disambiguate, so no ambiguous categorical-color cycling). - brand.css: add validated --series-5 (yellow) / --series-6 (red) riding VS Code chart tokens; overlay ceiling 4 -> 6. Palette passes the dataviz validator (lightness band, chroma floor, adjacent CVD, contrast) on dark and light surfaces; order puts yellow before red so green(4) never neighbours red. - Metrics move to a left rail beside the plot (was a full-width wrapping row of uneven tiles). Order: fidelity hero · objective(+trace) · iteration · feasibility · optimality; collapses above the plot when docked narrow. - Fix fidelity != objective: the convergence sparkline (the OBJECTIVE trace) lived inside the hero card, which was relabeled "fidelity" on completion — so a "fidelity" card sat over a plot of the objective. The sparkline now belongs to the objective card; fidelity is its own scalar hero. Host<->webview message protocol and the shell/CSP contract are unchanged; only the view DOM/CSS (design lane, free to change per the contract test) is touched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
aarontrowbridge
added a commit
that referenced
this pull request
Jul 11, 2026
…gn to #117 idiom) Mirror the Run Inspector's reveal gate on the Device Inspector so the panel is strictly button-press-only and VS Code never restores/auto-opens it: - package.json: add "when": "amicode.deviceInspectorRevealed" to the view. - device_inspector.ts: add DEVICE_INSPECTOR_CONTEXT_KEY + revealDeviceInspector() (setContext true → focus), structurally identical to INSPECTOR_CONTEXT_KEY / revealInspector; reveal() now funnels through it instead of a bare focus. - extension.ts: amicode.openDeviceInspector calls revealDeviceInspector(). - test: assert the reveal order (setContext true → focus) and the package.json gate. No webview-internal (overlay/metrics-rail) changes — that lane is Kate's. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redesign of the Run Inspector pane (design lane — the host↔webview protocol and the shell/CSP contract are untouched).
What changed
lo == hibounds.fidelityhero ·objective(+ convergence trace) ·iteration·feasibility·optimality. Collapses above the plot when the panel is docked narrow.fidelityon completion — so a card labeled "fidelity" ended up drawn over a plot of the objective function. The sparkline now belongs to theobjectivecard;fidelityis its own scalar hero.Palette (two new categorical colors)
brand.cssgains--series-5(yellow) and--series-6(red), both riding--vscode-charts-*tokens so they adapt to the user's theme, with dark-tuned hex fallbacks. Validated with the dataviz palette checker — PASS on lightness band, chroma floor, adjacent-pair CVD, and contrast for both dark (#1e1e1e) and light (#ffffff) surfaces. Ordering is deliberate: yellow at slot 5 keeps green(4) adjacent to yellow, not red, so the red/green pair (CVD's weakest) is never adjacent. Six is the ceiling — VS Code exposes exactly six chart hues — so past it the plot facets rather than inventing a 7th hue.Verification
pnpm typecheck/pnpm test/pnpm buildin my environment (no npm/deps available). Relying on CI here — please confirm the checks pass before merge. The existinginspector_view_contract/inspector_webview_viewtests pin the protocol +.pane/.active/.pill, which are unchanged.🤖 Generated with Claude Code