S8: Repair the dev-tools Rebuild surface for the overlay-build world (#1115) - #1123
Merged
jeonghun-jj-lee merged 1 commit intoSep 14, 2026
Merged
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jeonghun-jj-lee
force-pushed
the
jj/1115-rebuild-surface
branch
from
September 14, 2026 05:09
96bb82c to
205f29e
Compare
#1115) Restore two distinct Rebuild semantics and retire the fork-era wiring left behind by fork absorption (#1091): - Standardize the rebuild request mode on `local | main` end to end (UI → controller → payload → handler → tests). `local` builds the working tree as-is (no git checkout/pull); `main` fetches + checks out main + ff-only pulls before building. The handler now HONORS the mode via two pure helpers (resolveRebuildMode, rebuildGitCommand) — the git step is the one place the two buttons diverge. The retired `remote` value coerces to the safe `local`. - Remove the dead "opencode repo path" field: the UI row, the controller getter/setter/commit + payloads, the settings-context type/default/getter/ setter, and the opencodePath row key from all 18 locale files. - Retire the binary live-swap: drop the two path-fed opencodeBinary writes in the dev-tools-update handler and delete the deprecated appBundleBuildCommand / mainOverlayVerificationCommand shims. The general opencodeBinary override is preserved (boot/health consumer) and still cleared on toggle-off. - ADR 0018 records the two-button model + live-swap retirement; CONTEXT.md gains the Rebuild (local) / Rebuild (from main) / binary live-swap (retired) glossary terms. Tests: extend the chat-bridge and i18n suites (reuse-first) — mode/git-command helper assertions, binary-override lifecycle, and a locale key-removal guard. Rebased onto integration @4966b2d4 (engine-sync 8608dcc1). Refresh manifest for this slice's overlay edits (18 i18n + developer-tools controller/view + settings + rebuild-label-rename.test) so the overlay stays drift-clean against the 8608 manifest; exceptions bucket reconciled (23 amicode-only modules kept as exceptions, mirroring main). drift_gate PASS; tsc shows only the pre-existing coordinator pendingPromotion red (cleared by S10).
jeonghun-jj-lee
force-pushed
the
jj/1115-rebuild-surface
branch
from
September 14, 2026 05:30
205f29e to
9eef760
Compare
jeonghun-jj-lee
marked this pull request as ready for review
September 14, 2026 05:35
jeonghun-jj-lee
merged commit Sep 14, 2026
e005a3a
into
jj/1091-absorb-opencode-fork
11 checks passed
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1115. Part of #1091.
Restores two distinct rebuild semantics (
local= build working tree as-is;main= checkout main + ff-pull then build), removes the dead opencode-path field + the binary live-swap it fed, standardizes the mode vocabulary tolocal/main(retires fork-eraremote), and lands ADR 0018 + CONTEXT glossary. Diff: 26 files incl. 18 i18n locales.Gate (director-run): diff exact;
git grep opencodePathclean over overlay app src; typecheck shows only the pre-existingcoordinator.ts:137 pendingPromotion(S10-scoped, this slice doesn't touch it); 5 pre-existing env-dependent test failures, 0 new (proven by reverting the two extension files → identical failures). Draft until S10 clears the pre-existing typecheck red.Merge order for green: S9 → S10 → S8. Merge is human-gated.