S9: Retire the fork-based rebuild shell scripts (#1116) - #1122
Merged
jeonghun-jj-lee merged 1 commit intoSep 14, 2026
Merged
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Delete the two fork-era rebuild scripts that predate fork absorption (#1091) and have no in-tree callers: - scripts/rebuild_amicode_locally.sh (built the fork binary with bun from a local opencode fork checkout) - scripts/rebuild_amicode_remotely.sh (downloaded the pinned fork release binary) The in-app Rebuild surface (S8) is the supported dev path; these fork-clone / fork-release-download flows have no analog in the overlay-build world. Also correct the one rebuild coordinator docstring line that still claimed the shell scripts call it. Coordinator logic and the fork-mode comments (S10, #1117) are untouched. Refs #1116, part of #1091.
jeonghun-jj-lee
force-pushed
the
jj/1116-retire-fork-scripts
branch
from
September 14, 2026 05:02
1ca5ea5 to
dea7a2d
Compare
jeonghun-jj-lee
merged commit Sep 14, 2026
dea7a2d
into
jj/1091-absorb-opencode-fork
10 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1116. Part of #1091.
Deletes the two fork-based rebuild shell scripts (
rebuild_amicode_locally.sh,rebuild_amicode_remotely.sh— no in-tree callers) and corrects the one coordinator docstring line that named them. Diff: 3 files, +2/−322.Gate (director-run): typecheck clean w.r.t. this slice (only the pre-existing
coordinator.ts pendingPromotionerror remains — cleared by S10 #1117); no new test failures (revert-regression proof + independent confirm). Draft until the integration branch's pre-existing typecheck red is cleared by S10.Merge order for green: S9 → S10 → S8. Merge is human-gated.