fix(build): auto-invalidate stale .materialized cache when overlay changes - #1057
Merged
Conversation
…anges The build_app_bundle.mjs script reuses .materialized when package.json exists, regardless of whether the overlay has changed. This means a local rebuild after an overlay sync silently ships the old bundle — which is how the startsWith-undefined-title fix (PR #337 / #1011) failed to reach the installed VSIX despite the source being correct. Fix: read manifest.json's fork_sha + promoted_at, compare against a .overlay-stamp file inside .materialized, and wipe + re-materialize when they differ. The stamp is written after each materialization and backfilled for existing trees on the first run.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
build_app_bundle.mjsreuses.materializedwhenpackage.jsonexists, regardless of whether the overlay has changed since the last materialization. After an overlay sync (e.g. PR #1011 syncing thestartsWithfix from opencode PR #337), a local rebuild silently ships the old bundle because the cached tree still contains the pre-fix source.This is what caused the
TypeError: Cannot read properties of undefined (reading 'startsWith')to persist in the installed extension even though the source code fix was merged and the overlay was synced.Fix
Read
manifest.json'sfork_sha+promoted_atas the overlay version identity. Compare it against a.overlay-stampfile inside.materialized:The
--direct-worktreeand--verified-mainmodes are excluded from this check (they manage their own trees).Testing
Verified all three paths locally: