fix(skills): dream-reflect routing/schema + amico-schema-check table aligned to amico-vault (F10 repo side, #1050)

[aarontrowbridge]

Closes #1050 — the repo-rooted half of skills-integrity finding F10 (vault side: armonissima PR #92).

Adjudication note — option (b): dream-reflect relocates to the team vault

The earlier escalation asked how to reconcile #1050's deliberate surface: internal flip with ADR-0011's guards. The director chose full ADR-0011 consistency: internal stays vault-only, so the in-repo library copy of dream-reflect is removed (commit ca2c5590, superseding the flip-only state of ff0024eb). The card's fixes — personal-vault retro routing, the required outcome frontmatter field, surface: internal — travel with the card to the team vault; the relocation PR is filed in parallel, see the campaign ledger.

Shipping consequence (deliberate): dream-reflect stops shipping to customers — which aligns it with its dream-family siblings (dream-distill, dream-prune, dream-connect, dream-synthesize were never in the shipped library). The two ADR-0011 guards that flagged the in-repo internal flip (packaging.test.ts AC4 leak guard, package_skills.test.ts surface guard) are restored green with the copy gone.

What is in this PR now

• packages/extension/skills/dream-reflect/SKILL.md — deleted (the whole card directory). The fixed card lives on vault-side; see the relocation PR.
• packages/extension/skills/amico-schema-check/SKILL.md — kept exactly as originally reviewed (below).

amico-schema-check — table aligned to amico-vault (the single owner)

• The schema table now mirrors amico-vault field for field, with an explicit do-not-extend-here note:
  • insight drops the phantom required source, gains session_id
  • experiment keeps task_type/duration_us (amico-vault has them), reordered to the authority's order
  • paper gains title, date_read (replacing the wrong date), relevance, systems, session_id
  • spec/plan gain session_id + visibility, drop nullable priority/platform
  • retrospective gains session_id + outcome
  • org gains domain + relationship; device gains device_class + location; meeting gains org + topic
  • new rows amico-vault defines that this card lacked: hopper, system-context, research-brief, charter, reference, note — plus control-hardware and project on the generic floor (date + session_id + tags, per amico-vault's "the floor every note type meets")
• Auto-fix/flag mechanics sections untouched, as the issue requires.

Deletion audit — nothing enumerates the repo library by dream-reflect

Checked before deleting: no test, agent card, mode pack, or fixture references dream-reflect by name. The skills-dir assertions that look like counts are all deletion-safe (package_skills.test.ts's are tag-relative — both sides shrink together; skill_drift_lint.test.ts's aggregate.skills === 6 is fixture-scoped, not repo-scoped). One cosmetic mention survives in packages/app-bundle/overlay/.../brain-data.ts (a knowledge-graph viz node in the read-only fork tracking copy — not a manifest, not a build input; fork-side, untouched per the overlay rules). No enumeration fixture needed fixing.

Verification

pnpm --filter amicode test, fresh worktree on this branch:

	failed	passed	skipped
pristine origin/main (baseline)	5	3389	48
after the flip (previous state)	7	3387	48
after relocation (this PR)	5	3389	48

The 5 remaining failures are the pre-existing environmental baseline, by name: amicode_service_runner ×1 (app dist not built in a fresh worktree), chat_bridge ×2 (dev-tools symlink cleanup), skill_drift_lint ×2 (Strumento.jl fleet packages not present on this machine). The two ADR-0011 guard failures introduced by the flip are gone. Branch diff vs main is exactly two files.

node packages/extension/scripts/lint-skills.mjs — absent on main (it lives on the separate #1046/#1045 branch), skipped per instructions.

Out-of-scope flag (follow-up candidate, not touched here)

packages/extension/vault-schemas/generate.mjs has a LEGACY block whose comment says it mirrors "the amico-schema-check table" — it carries the old table's drift too (e.g. insight requires source there, and the committed vault-schemas/cards/*.schema.json inherit it). The single-owner cleanup should extend to it as a separate slice; vault_schemas.test.ts pins those committed schemas against fixtures, so it belongs with its own RED→GREEN cycle.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: e896eedf-289e-4c73-ab92-78cf226dbaad

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}