fix(fleet): the way back from standalone — alias-substituting installer + Fleet — Enroll - #1034
Merged
Merged
Conversation
…ploy receipt The installer copied the tunnel plist template verbatim, shipping a literal FLEET_SSH_ALIAS placeholder — launchd looped forever on 'could not resolve hostname fleet_ssh_alias' while --check reported all-ok (it never checked the alias). Now: - install.sh (both copies — root + packaged) reads canonical.sshAlias from fleet.json, substitutes it (and the port) into the plist at install, refuses to install a tunnel with no alias, and --check fails loudly on an unsubstituted placeholder or a wrong alias - reconciles the parallel uncommitted fix in the packaged copy (same intent, written twice — the duplicate is now byte-identical to the root) - regenerates the agent-cards deploy receipt for the current 7-card source set (the committed receipt still named the retired autodev/autoresearch cards, flagging agent-cards surfaces stale on every fleet machine)
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
aarontrowbridge
changed the title
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way back from standalone. See commit messages for the full detail: 2f180d3 (Fleet — Enroll + standalone status-bar item — #338 called re-enrollment 'a separate flow'; this is that flow) and 0f82a62 (alias-substituting installer + deploy-receipt refresh — the placeholder that looped launchd on an unresolvable hostname while --check said all-ok).
Incident chain (2026-09-12, MacBook, observed live three times): broken installer → placeholder tunnel → panel stuck booting → 10-second 'Go Standalone?' trap dialog ate the rejoin → standalone hid the status-bar item entirely → no in-UI way back.
Verification: fleet_fallback 9/9 (3 new enroll tests); build green; the 4 unrelated suite failures on this tree are uncommitted WIP (verified passing on clean main on erlich); three live rejoin/recovery cycles driven by this code; installer --check green with synthetic-placeholder detection.