fix: scroll snap-back in dashboard surfaces (#1012) - #1024
Merged
Conversation
Reviewed spec covering three root causes across four candidate surfaces: - Cause A: sessionListDirectories fresh-array churn → arraysEqual utility - Cause B: Show-gate unmount on refetch → .latest pattern - Cause C: md:overflow-hidden gap → unconditional clip Implementation lives in the opencode fork branch fix/scroll-snap-back-1012. All 1151 fork tests + 3235 amicode tests pass.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… in materialize The overlay promotion at ce1877d wrote upstream_base as a raw commit SHA (16747470f976...) instead of the tag name (v1.18.29). materialize.mjs builds the upstream tarball URL as /archive/refs/tags/<value>.tar.gz, which only works for actual tag names — a raw SHA returns 404. Two fixes: 1. Restore upstream_base to 'v1.18.29' (the tag name). 2. Make materialize.mjs detect a raw hex SHA and use /archive/<sha>.tar.gz (the commit path) instead of /archive/refs/tags/ — so a future accidental SHA write doesn't break CI again. Unblocks the vsix-gate CI job that has been failing on main since ce1877d.
jeonghun-jj-lee
marked this pull request as ready for review
September 11, 2026 20:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1012
Summary
Three targeted fixes for the scroll-position-reset bug reported on WSL2 (linux-x64).
Fix 1 — Structural equality on
sessionListDirectoriesconsumersarraysEqualutility fromhelpers.tsprojectDirectoriesmemo (home.tsx) and newflyoutDirectoriesmemo (session-header.tsx)Fix 2 — Use
.lateston widget/dashboard resourceswidgetsRaw()/dashboardRaw()with.latestin widgetInfos and dashboard memoshomeCardsLoadingnow gates on initial load only (no.latestyet), not any loading stateFix 3 — Drop
md:prefix fromoverflow-hiddenon home shellImplementation
All code changes are in the opencode fork branch
fix/scroll-snap-back-1012. This PR carries the reviewed spec; the overlay sync and version pin will land after the fork branch merges.Tests
arraysEqualunit tests + 8 structural tests)Open question
The exact surface has not been confirmed — @bc037, a screen recording would resolve this.