Skip to content

Fix narrow-screen layout and SQL prefill bugs - #2

Merged
hami9 merged 1 commit into
mainfrom
fix/narrow-screen-layout
Sep 30, 2026
Merged

hami9 merged 1 commit into
mainfrom
fix/narrow-screen-layout

Conversation

@hami9

@hami9 hami9 commented Sep 30, 2026 •

Copy link
Copy Markdown
Owner

Found while testing v1.4.0 on a Galaxy S9 (360dp wide, Android 10). None of these show up on a wider screen.

Before Fix
System screen printed Supported ABIsarm64-v8a, armeabi-v7a — label and value with no gap label and value share the row; value is end-aligned
Profile badge wrapped one word per line: Teleg / ram / Bot badge stays on one line; project name ellipsizes
Services log filter drew ERROR one letter per line the chip row scrolls sideways
Services subtitle ran under the Stop All button header title column is weighted

The database browser's SQL box was hardcoded to SELECT * FROM tasks LIMIT 25 while the view model ran a query for the first table it found, so the box showed a query that was never executed (visible in the screenshot: that text above android_metadata's single locale row). In any project without a tasks table, pressing Execute SQL on the pre-filled text failed with no such table: tasks. It now follows the query that actually runs.

Not verified locally: this machine has no JDK 21 or Android SDK right now, so CI is the compile check. Screenshots of the three affected screens are not in the README yet — they should be retaken from a build that includes this change.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Usability Improvements
    • The database screen now starts with an empty SQL input and selects up to 25 rows from the first available table when a database is selected.
    • Health information columns are evenly spaced, with values aligned consistently.
    • Long project and profile names stay on one line, with project names truncated when needed.
    • Log filters can scroll horizontally, and the “Stop All” label stays on one line.

Testing v1.4.0 on a Galaxy S9 (360dp wide) showed four defects that do
not appear on a wider screen:

- The System screen ran labels into their values: "Supported ABIsarm64-v8a,
  armeabi-v7a". Both texts sat in a SpaceBetween row with nothing
  reserving space, so a wrapping value closed the gap. The label and value
  now share the row and the value is end-aligned.
- A profile badge wrapped one word per line, printing "Teleg / ram / Bot"
  as a three-line block next to the project name.
- The Services log filter drew "ERROR" one letter per line, because five
  chips did not fit the width. The chip row scrolls sideways now.
- The Services subtitle ran underneath the "Stop All" button, which itself
  wrapped onto two lines.

The SQL box in the database browser was hardcoded to
"SELECT * FROM tasks LIMIT 25" while the view model executed a query for
the first table it found, so the box showed a query that was never run —
the screenshot showed that query above android_metadata's single row. In
any project without a `tasks` table, pressing Execute SQL on the
pre-filled text also failed. It now follows the query that runs.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: fb80778e-40d1-4c5c-b097-07813525e949

📥 Commits

Reviewing files that changed from the base of the PR and between 63c191f and 83d0c55.

📒 Files selected for processing (5)
  • app/src/main/java/com/runcode/app/ui/screens/DatabaseScreen.kt
  • app/src/main/java/com/runcode/app/ui/screens/HealthScreen.kt
  • app/src/main/java/com/runcode/app/ui/screens/HomeScreen.kt
  • app/src/main/java/com/runcode/app/ui/screens/ProjectsScreen.kt
  • app/src/main/java/com/runcode/app/ui/screens/ServicesScreen.kt
 ______________________________________________________________________________________________________________________
< Design with contracts. Use contracts to document and verify that code does no more and no less than it claims to do. >
 ----------------------------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@hami9
hami9 merged commit ca765da into main Sep 30, 2026
1 of 2 checks passed
@hami9
hami9 deleted the fix/narrow-screen-layout branch September 30, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant