Skip to content

The FFT app doesn't actually work for 1D ffts - #9449

Merged
mcourteaux merged 1 commit into
mainfrom
abadams/fix_fft_infinite_loop
Sep 15, 2026
Merged

mcourteaux merged 1 commit into
mainfrom
abadams/fix_fft_infinite_loop

Conversation

@abadams

@abadams abadams commented Sep 14, 2026

Copy link
Copy Markdown
Member

The FFT app seems to advertise support for 1D ffts in the generator params, but if you actually invoke it with the default generator params it hits an infinite loop in the radix helper function for size 0, and fails an assert in the inner fft function for size 1. This app really only does non-trivial 2D ffts.

This was triggered by running the generator directly with default generator params and seeing all my memory get consumed by an ever-increasing vector of radix factors.

The FFT app seems to advertise support for 1D ffts in the generator
params, but if you actually invoke it with the default generator params
it hits an infinite loop in the radix helper function for size 0, and
fails an assert in the inner fft function for size 1. This app really
only does non-trivial 2D ffts.

This was triggered by running the generator directly with default
generator params and seeing all my memory get consumed by an
ever-increasing vector of radix factors.
@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.10%. Comparing base (e02a03f) to head (dd9a7e4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9449      +/-   ##
==========================================
+ Coverage   70.03%   70.10%   +0.06%     
==========================================
  Files         261      261              
  Lines       79802    79802              
  Branches    19455    19455              
==========================================
+ Hits        55892    55943      +51     
+ Misses      17997    17992       -5     
+ Partials     5913     5867      -46     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcourteaux
mcourteaux merged commit 5614da8 into main Sep 15, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants