The FFT app doesn't actually work for 1D ffts - #9449
Merged
Merged
Conversation
The FFT app seems to advertise support for 1D ffts in the generator params, but if you actually invoke it with the default generator params it hits an infinite loop in the radix helper function for size 0, and fails an assert in the inner fft function for size 1. This app really only does non-trivial 2D ffts. This was triggered by running the generator directly with default generator params and seeing all my memory get consumed by an ever-increasing vector of radix factors.
alexreinking
approved these changes
Sep 14, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9449 +/- ##
==========================================
+ Coverage 70.03% 70.10% +0.06%
==========================================
Files 261 261
Lines 79802 79802
Branches 19455 19455
==========================================
+ Hits 55892 55943 +51
+ Misses 17997 17992 -5
+ Partials 5913 5867 -46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mcourteaux
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FFT app seems to advertise support for 1D ffts in the generator params, but if you actually invoke it with the default generator params it hits an infinite loop in the radix helper function for size 0, and fails an assert in the inner fft function for size 1. This app really only does non-trivial 2D ffts.
This was triggered by running the generator directly with default generator params and seeing all my memory get consumed by an ever-increasing vector of radix factors.