Reject failed generator-cache output replacement

[gregcotten]

Fixes #9437.

A cache hit can currently leave an older pipeline's output on disk and still return success. When rename fails, try_restore does not check whether its fallback copy succeeded.

We investigated this after a Windows OpenCL AOT build appeared to keep an earlier implementation despite rebuilding the generator, prompting us to disable semantic caching. This reproducer demonstrates a mechanism that can produce that symptom; it does not establish the cause of the original incident.

Check that copy, preserve the error message, clean pending temporary files, and fail the generator before it can report a hit. Successful rename and copy-fallback restores retain their behavior; cache keys and the cache format are unchanged. The existing correctness test gains a nonempty-directory obstruction and verifies restoration after removing it.

The standalone CPU reproducer demonstrates the bug with Windows sharing locks. The same shared restore defect was also reproduced on macOS with an immutable archive.

Local Windows verification before rebasing: a full shared Halide build passed correctness_generator_cache, correctness_compile_to, and correctness_compile_to_multitarget. The normal CMake test/integration/cache project passes both its generated-code execution test and cache-population check. The standalone reproducer against that full DLL reports nonzero status and no hit for locked objects/archives, then restores the requested bytes after unlocking. Successful control objects and archives are byte-identical to the original wheel's controls.

The new regression also fails against the original halide-bin==22.0.0.dev390 wheel. Earlier focused-fixture checks cover temporary-file cleanup and successful copy fallback. clang-format 21.1.8 and git diff --check pass. Full-build environment: Windows x64, C++20, MSVC 19.42 compiler, isolated 14.44 linker/CRT libraries, Windows SDK 10.0.22621.0, LLVM 22.1.8, serialization enabled. The newer link libraries are needed by the LLVM binary distribution; no installed toolchain was modified.

Remaining validation: static Halide linkage and patched macOS/Linux runs have not been tested locally. The branch includes #9436; CI and coverage results for the updated head are pending.

An output replacement failure is reported as a user error rather than a cache miss. Recompilation is not a reliable recovery in the presence of the separate Windows COFF archive writer defect in #9439, which ignores stream errors. Its producer-side fix is proposed in #9440. This PR handles restoration of an existing cache entry; #9440 handles fresh archive generation. The two fixes have been tested independently and together.

The test child reports CompileError as a nonzero exit so expected failures retain coverage profiles. Instrumented Windows verification confirmed that the failing child's profile was previously lost and is now written, while all cache checks still pass. This changes only the test harness; production error handling is unchanged.

[gregcotten]

@alexreinking, sorry these were committed with [skip ci] - I made a dummy commit to trigger workflows. Please approve! Needless to say this should be a squash merge

[alexreinking]

@gregcotten — could you please rebase on main? GitHub isn't picking up #9436.

[gregcotten]

@alexreinking done!

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.17%. Comparing base (58868f0) to head (b61f699).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
src/GeneratorCache.cpp	66.66%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9438      +/-   ##
==========================================
+ Coverage   69.95%   70.17%   +0.22%     
==========================================
  Files         261      261              
  Lines       79596    79621      +25     
  Branches    19400    19405       +5     
==========================================
+ Hits        55678    55872     +194     
+ Misses      18004    17955      -49     
+ Partials     5914     5794     -120     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.