Fix win_amd64 pip CI: skip all free-threaded builds, not just cp314t - #9430
Merged
Merged
Conversation
cibuildwheel 4.2.0 (#9402) started recognizing CPython 3.15, whose free-threaded cp315t-win_amd64 build hits the same MSVC link failure (missing pythonXY.lib) that cp314t-win_amd64 was excluded for. The version-agnostic `cp3??t-*` skip pattern already fixed this once (#9298), but the halide-bin/halide/halide-runtime package split (#9272) branched before that fix landed and reintroduced the narrower `cp314t-*` pattern, silently regressing it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
alexreinking
requested review from
abadams,
derek-gerstmann,
mcourteaux and
slomp
September 5, 2026 14:29
derek-gerstmann
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build halide-runtime wheels for win_amd64(andBuild Halide wheels for win_amd64) started failing on 2026-08-31 after Bump pypa/cibuildwheel from 4.1.1 to 4.2.0 #9402 bumped cibuildwheel to 4.2.0, which added recognition of CPython 3.15's free-threadedcp315t-win_amd64build target.cp314t-win_amd64(LINK1104: cannot open file 'python315.lib'), since CMake'sFindPython/pybind11 machinery probes for the non-timport lib name that doesn't exist for free-threaded interpreters.cp314t-*to the version-agnosticcp3??t-*. However, [python] Split Python packages and add standalone AOT runtime #9272 (the halide-bin/halide/halide-runtime package split) branched before that fix landed, and its rewrite ofpip.ymlreintroduced the narrowercp314t-*pattern in both new jobs — silently regressing the fix until cibuildwheel 4.2.0 madecp315tbuildable again.cp3??t-*in bothCIBW_SKIPlines so all free-threaded Windows variants are excluded regardless of Python version.Test plan
Build halide-runtime wheels for win_amd64andBuild Halide wheels for win_amd64pass on this PR🤖 Generated with Claude Code