Revert "verify serialized buffer before accessing it in the deserializer" - #9426
Merged
Merged
Conversation
alexreinking
approved these changes
Sep 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9426 +/- ##
==========================================
- Coverage 70.19% 70.12% -0.07%
==========================================
Files 261 261
Lines 79399 79393 -6
Branches 19361 19359 -2
==========================================
- Hits 55732 55677 -55
+ Misses 17886 17880 -6
- Partials 5781 5836 +55 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
5 tasks
abadams
pushed a commit
that referenced
this pull request
Sep 14, 2026
) * Raise flatbuffers verifier max_depth for pipeline deserialization PR #9395 added flatbuffer verification before deserializing a pipeline, but used the verifier's default max_depth (64). Each Stmt/Expr node serializes as one flatbuffer table, so any pipeline with a moderately deep expression nests past that and gets rejected as "malformed" even though it's valid -- this is what broke the serialization round-trip CI bot and led to the revert in #9426. Raise max_depth to 1000 at both verification call sites instead of reverting: comfortably covers the deepest of the correctness tests that were failing (~200-400), while still bounding the deserializer's recursive descent against a corrupt or adversarial buffer. Verified a corrupted buffer is still rejected. Adds test/correctness/serialization.cpp, a regression test covering both directions: a pipeline with an expression nested past the old default round-trips cleanly, and a corrupted buffer still throws. Co-authored-by: nashit hayat <nashit@bugqore.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> * Trigger CI --------- Co-authored-by: nashit hayat <nashit@bugqore.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #9395
Unfortunately the original PR didn't run on the one bot that tests serialization, and our round-trip testing shows that in a bunch of cases our flatbuffers fail to verify. This is obviously not a good thing, but we should temporarily revert this while figuring it out in order to keep CI green.