fix/restore paste on firefox - #31
Open
stanley2058 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR restores reliable access to the native “Paste” item in Firefox’s context menu by switching Firefox to the same “capture right-click early” path used for other affected browsers, and by ensuring the right-click cleanup runs even when Firefox doesn’t deliver the expected mouseup event on window.
Changes:
- Treat Gecko (Firefox) as a browser that needs
captureRightClickhandling. - In the right-click context menu hack, also listen for
contextmenuto trigger the cleanup path whenmouseupisn’t fired onwindow(modern Firefox behavior).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/util/browser.js | Expands captureRightClick to include Gecko so Firefox uses the early right-click handling path. |
| src/input/TextareaInput.js | Adds a contextmenu fallback listener to reliably run the re-hide cleanup after the native menu opens in Firefox. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before:


after: