Skip to content

"terraform-validate", "terraform-fmt" fails with "command not found" in Linux-based systems due to ^M carriage return character #65

Description

@MarioArriaga92

Describe the bug
"pre-commit run terraform-validate --all-files" command fails until I follow Remove the spurious CR characters steps to use sed to remove "The ^M is a carriage return character":
Screen Shot 2021-12-31 at 15 42 29

To Reproduce
Steps to reproduce the behavior including the relevant Terraform/Terragrunt/Packer version number and any code snippets and module inputs you used.

  1. Install pre-commit in Mac OS or some linux flavor OS (Ubuntu, etc.) & create a .pre-commit-config.yaml as defined in Pre-commit README.md > General Usage
  2. Run pre-commit run terraform-validate --all-files
  3. See failures, now run sed -i -e 's/\r$//' /Users/arriaga/.cache/pre-commit/repo57cjvft5/hooks/terraform-validate.sh
  4. Re-try pre-commit run terraform-validate --all-files and see how errors g oaway

Expected behavior
Maybe pre-commit hooks should avoid having the "^M" carriage return character?

Additional context
Tried to follow "Step 3 - Static Analysis" steps of Getting Started with Terraform on Azure: Testing blog article

Activity

  1. MarioArriaga92 commented on Jan 12, 2022

    @MarioArriaga92
    Author

    Any update?

  2. infraredgirl commented on Jan 12, 2022

    @infraredgirl
    Contributor

    Hi Mario, thanks for the bug report! It looks like you've already figured out the fix - would you mind submitting a quick PR?

  3. dsalaj commented on Jan 27, 2022

    @dsalaj

    I have the same issue with terraform-fmt in pre-commit v0.1.17. The solution of @MarioArriaga92 worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions