Repository navigation
fix: bump vite from 8.3.0 to 8.3.5 - #2454
dependabot[bot] wants to merge 5 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
🔍 PR Validation✅ Current validation passed. |
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
Dependency ReviewThe following issues were found:
|
groupthinking
left a comment
There was a problem hiding this comment.
Review at head 0bcf1cde: dependency-review fails with 'vulnerable packages' for this Vite update. Please identify the flagged package(s), fix or document the applicable exception under the repository's dependency-maintenance policy, and rerun the check. I cannot approve the current dependency set.
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 8.3.0 to 8.3.5. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v8.3.5/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 8.3.5 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
0bcf1cd to
f74733d
Compare
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
groupthinking
left a comment
There was a problem hiding this comment.
The earlier changes request at 0bcf1cde was triggered by certifi@2026.7.22 in uv.lock (GHSA-6q48-6c7w-9gw2), not by the Vite diff. Current main and this head both lock certifi 2026.10.19, beyond the advisory's patched 2026.10.18. Separately, the prior Vite head still installed vulnerable Vite 8.3.0 in the root test toolchain; this head resolves root and web to 8.3.5, and fresh npm audit has no Vite finding. Clean npm 10.8.0 install, 1,520 web tests, lint, build and hosted app checks pass. I approve this code change at db98346adc93dc42935c6b49c3fdefeaba71c1e7. The required dependency-review job still fails on a three-base/one-head snapshot mismatch and saves no evidence artifact, so this is not a merge recommendation or a complete dependency verdict.
Review update — 2026-10-28
At current head
db98346adc93dc42935c6b49c3fdefeaba71c1e7againstmainba2777d1b008c2148d413e07cc497791966310e0, the diff changesapps/web/package.jsonand the root lockfile for Vite 8.3.0 to 8.3.5. The root test toolchain had still installed vulnerable Vite 8.3.0 at the prior head; this head deduplicates root and web onto 8.3.5 with related Rolldown/Oxc lock entries. Root Vitest/tinyrainbow entries are unchanged. The original Dependabot notes follow below.Validation: clean npm 10.8.0 install, 1,520 web tests with 28 skipped, lint, web build and diff check passed.
npm ls viteresolves root and web to 8.3.5, and freshnpm audithas no Vite finding; 32 package-tree findings remain, so this is not a complete security clearance. Hosted checks at this head finished with 23 passing, three skipped and one failed, plus two successful deployment statuses. The faileddependency-reviewjob compared three base snapshots with one head snapshot and showed unrelated removals; its evidence recording hitMaximum object size exceeded, so no artifact was uploaded. The dependency verdict remains incomplete, tracked by issue #2490 and PR #2487. Keep this PR open until a warning-free comparison and complete evidence are verified.Original Dependabot notes
Bumps vite from 8.3.0 to 8.3.5.
Release notes
Sourced from vite's releases.
... (truncated)
Changelog
Sourced from vite's changelog.
... (truncated)
Commits
981f07frelease: v8.3.5 (#23856)0d86b34fix(resolve): support subpath imports with multiple#(#23631)6a02780perf(ssr): extract inline source maps without a regexp (#23775)8e890e1fix(optimizer): skip patches dir check for yarn.lock fallback (#23725)197daf6fix(bundled-dev): declare utf-8 charset in fallback page (#23846)4d16e7cfix(build): include preload dependencies to chunk import map hashing (#23793)df7b40erefactor(dev): consolidate moduleURL to file path utilities (#23828)a162990refactor(dev): use ModuleURLs throughout HTML transforms (#23815)6116689refactor(dev): separate import resolution from URL conversion (#23791)446954crefactor(dev): share ModuleURL and BrowserURL conversions (#23790)